-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: MultiIndex.to_hierarchical #21613
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
79d19e4
Initial commit
KalyanGokhale 007f26f
Fixed Depcrecation issue with Sphinx directive
KalyanGokhale cd78d93
Fixed Sphinx deprecation build error
KalyanGokhale 8727f95
Updated issue number
KalyanGokhale 7aa3bbf
Suppressed warnings
KalyanGokhale 2e5a6da
Force Travis rerun
KalyanGokhale 3eedafc
Force Travis rerun
KalyanGokhale 1d2eb26
Updated for comments
KalyanGokhale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -948,10 +948,14 @@ def to_frame(self, filter_observations=True): | |
data[item] = self[item].values.ravel()[selector] | ||
|
||
def construct_multi_parts(idx, n_repeat, n_shuffle=1): | ||
axis_idx = idx.to_hierarchical(n_repeat, n_shuffle) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you provide a 1-liner what this method is doing |
||
labels = [x[selector] for x in axis_idx.labels] | ||
levels = axis_idx.levels | ||
names = axis_idx.names | ||
# Replicates and shuffles MultiIndex, returns individual attributes | ||
labels = [np.repeat(x, n_repeat) for x in idx.labels] | ||
# Assumes that each label is divisible by n_shuffle | ||
labels = [x.reshape(n_shuffle, -1).ravel(order='F') | ||
for x in labels] | ||
labels = [x[selector] for x in labels] | ||
levels = idx.levels | ||
names = idx.names | ||
return labels, levels, names | ||
|
||
def construct_index_parts(idx, major=True): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to_hierarchical is listed elsewhere in this file in a doc-string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - it is mentioned as a part of enumeration of methods of
MultiIndex
- should it be removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - updated for all of the latest review comments