[REF] separate blocks.py out of internals.__init__ #22014
Conversation
|
Hello @jbrockmendel! Thanks for updating the PR.
Comment last updated on July 21, 2018 at 22:16 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #22014 +/- ##
==========================================
+ Coverage 91.99% 91.99% +<.01%
==========================================
Files 167 168 +1
Lines 50578 50595 +17
==========================================
+ Hits 46530 46547 +17
Misses 4048 4048
Continue to review full report at Codecov.
|
pandas/core/internals/blocks.py
Outdated
|
|
||
| mask = mask.any(0) | ||
| new_values = new_values.T[mask] | ||
| new_placement = new_p |
There was a problem hiding this comment.
this prob doesn't belong here (move in future)
pandas/core/internals/blocks.py
Outdated
|
|
||
| mask = mask.any(0) | ||
| new_values = new_values.T[mask] | ||
| new_placement = new_p |
There was a problem hiding this comment.
this doesn't belong here), actually a lot of things done't belong here. but I suppose that's for followups.
|
thanks, ok for now. This needs further splitting (and ultimately everything should be moved out of |
| @@ -5,7 +5,8 @@ | |||
|
|
|||
| import pandas as pd | |||
| from pandas.core.internals import ( | |||
| BlockManager, SingleBlockManager, NonConsolidatableMixIn, Block) | |||
| BlockManager, SingleBlockManager) | |||
| from pandas.core.internals.blocks import Block, NonConsolidatableMixIn | |||
There was a problem hiding this comment.
For next PRs doing further splitting, can we please keep the existing imports?
What I mean is: import all the things that are used in pandas outside of internals itself in internals/__init_.py, then no changes to imports are needed, and it is also clear which functions/classes are used in the rest of pandas.
There was a problem hiding this comment.
For next PRs doing further splitting, can we please keep the existing imports?
Yes. I'm also marking which non-internals modules are importing what, in the hopes we can trim down the exposed surface.
Follow-up to #21903