Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Option to return -inf/inf as lower/upper bound of quantiles, see… #22097

Closed
wants to merge 1 commit into from
Closed

ENH: Option to return -inf/inf as lower/upper bound of quantiles, see… #22097

wants to merge 1 commit into from

Conversation

dberenbaum
Copy link

Add bounded keyword arg to quantile and qcut functions to enable unbounded quantiles with lower/upper bounds of -inf/inf.

@pep8speaks
Copy link

Hello @dberenbaum! Thanks for submitting the PR.

Line 241:70: W291 trailing whitespace

jreback
jreback requested changes Jul 28, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • needs tests
  • bounds is a new kwarg so add it at the end
  • default must be False to avoid back compat issues

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Enhancement labels Jul 28, 2018
@dberenbaum
Copy link
Author

Closing for now to rework this PR.

@dberenbaum dberenbaum closed this Jul 30, 2018
@dberenbaum dberenbaum deleted the qcut-unbounded branch July 30, 2018 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Enhancement Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qcut: Option to return -inf/inf as lower/upper bound
3 participants
@dberenbaum @pep8speaks @jreback