Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Remove unused method #22321

Merged
merged 1 commit into from
Aug 14, 2018
Merged

CLN: Remove unused method #22321

merged 1 commit into from
Aug 14, 2018

Conversation

alimcmaster1
Copy link
Member

  • [y] passes git diff upstream/master -u -- "*.py" | flake8 --diff

This method isn't used anywhere in the codebase, good to delete?

@alimcmaster1 alimcmaster1 mentioned this pull request Aug 13, 2018
Closed
@gfyoung gfyoung requested review from jreback and toobaz August 13, 2018 20:17
@gfyoung gfyoung added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex Clean labels Aug 13, 2018
@alimcmaster1 alimcmaster1 changed the title Remove unused method CLN: Remove unused method Aug 13, 2018
toobaz
toobaz approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@toobaz toobaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch (it was created in 2012 and probably never used after 2012 :-) )

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #22321 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22321      +/-   ##
==========================================
+ Coverage   92.08%   92.08%   +<.01%     
==========================================
  Files         169      169              
  Lines       50706    50703       -3     
==========================================
- Hits        46691    46689       -2     
+ Misses       4015     4014       -1
Flag Coverage Δ
#multiple 90.49% <ø> (ø) ⬆️
#single 42.33% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 95.41% <ø> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601d71f...ac64c8e. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Aug 14, 2018
@jreback jreback merged commit 1ea9664 into pandas-dev:master Aug 14, 2018
@jreback
Copy link
Contributor

jreback commented Aug 14, 2018

thanks! improved coverage!

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@alimcmaster1
Remove unused method (pandas-dev#22321)
4da24d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toobaz toobaz toobaz approved these changes

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alimcmaster1 @jreback @toobaz @gfyoung