Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: modernize string formatting #22553

Merged
merged 1 commit into from
Sep 1, 2018
Merged

Conversation

jbrockmendel
Copy link
Member

Broken off from #22283.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward lgtm on green

@WillAyd WillAyd added the Clean label Aug 31, 2018
@codecov
Copy link

codecov bot commented Aug 31, 2018

Codecov Report

Merging #22553 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22553   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50787    50787           
=======================================
  Hits        46745    46745           
  Misses       4042     4042
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 42.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98fb53c...30258c6. Read the comment docs.

@jbrockmendel
Copy link
Member Author

@WillAyd green; think we're OK merging without waiting on the senior guys?

@WillAyd WillAyd merged commit 77e53b8 into pandas-dev:master Sep 1, 2018
@WillAyd
Copy link
Member

WillAyd commented Sep 1, 2018

Yep

@jbrockmendel jbrockmendel deleted the cyformat branch September 1, 2018 17:31
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants