-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Formatting in Series.str.extractall #22565
DOC: Formatting in Series.str.extractall #22565
Conversation
…e end of the parameter descriptions. Can also clarify descriptions if useful.
Can you check comments in #22562 and see if they make sense for the changes here too? |
Hello @lucadonini96! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 01, 2018 at 14:15 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #22565 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 169 169
Lines 50787 50787
=======================================
Hits 46745 46745
Misses 4042 4042
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes, added just couple of minor things
@@ -1000,7 +1004,6 @@ def str_extractall(arr, pat, flags=0): | |||
1 a 2 | |||
B 0 b 1 | |||
C 0 NaN 1 | |||
|
|||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this blank line at the end before the quotes.
A ``DataFrame`` with one row for each match, and one column for each | ||
group. Its rows have a ``MultiIndex`` with first levels that come from | ||
the subject ``Series``. The last level is named 'match' and indexes the | ||
matches in each item of the ``Series``. Any capture group names in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in DataFrame
... is better to use backticks, as they are more "links to other pages" than "code" in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant single backticks in the previous comment, instead of double backticks.
In Series.str.extractall, corrected the formatting in the return value and added a period at the end of the parameter descriptions. Can also clarify descriptions if useful.
git diff upstream/master -u -- "*.py" | flake8 --diff