Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Updating str_repeat docstring #22571

Merged
merged 9 commits into from
Sep 18, 2018

Conversation

JesperDramsch
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Sep 1, 2018

Hello @JesperDramsch! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on September 02, 2018 at 09:54 Hours UTC

@blylei
Copy link

blylei commented Sep 1, 2018

hahahah

@gfyoung gfyoung added Docs Strings String extension data type and string data labels Sep 1, 2018
@gfyoung
Copy link
Member

gfyoung commented Sep 1, 2018

https://travis-ci.org/pandas-dev/pandas/jobs/423383576#L3419

@JesperDramsch : Looks like you have a linting failure here.

@codecov
Copy link

codecov bot commented Sep 2, 2018

Codecov Report

Merging #22571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22571   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50787    50787           
=======================================
  Hits        46745    46745           
  Misses       4042     4042
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 42.29% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/strings.py 98.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98fb53c...a252aa7. Read the comment docs.

@gfyoung
Copy link
Member

gfyoung commented Sep 2, 2018

@JesperDramsch : I like the change! FYI, Anaconda is having some serious servicing issues, so our CI is not going to work at all for the time being.

@JesperDramsch
Copy link
Contributor Author

Alright then I'll chill out and enjoy the view.

Copy link

@jeffyancey jeffyancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good to me, just a couple questions and observations.

>>> s
0 a
1 b
2 c

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that it is necessary, be I do see that elsewhere in our examples the dtype: object is included beneath the series printout.


Parameters
----------
repeats : int or array
Same value for all (int) or different value per (array)
repeats : int or sequence of int

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sequence of int might be fine, and maybe 'sequence' is a term that has a clear definition in the pandas community, but I often see array_like used in the numpy documentation. Not really recommending anything, just curious is sequence is used similarly here, or you were just using to to indicate a list/array/tuple/etc of integers.

@jreback
Copy link
Contributor

jreback commented Sep 18, 2018

@datapythonista

@datapythonista
Copy link
Member

Finally merging this. We can add improvements from #20634 later on in a new PR.

@datapythonista datapythonista merged commit 9dd454e into pandas-dev:master Sep 18, 2018
@datapythonista
Copy link
Member

Thanks @JesperDramsch

aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Sep 20, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@JesperDramsch JesperDramsch deleted the str_repeat-docstring branch October 4, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants