-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: Rename 'n' to 'repeats' in .repeat methods #22574
Conversation
For Index and MultiIndex. xref pandas-devgh-14645.
17f18f2
to
780019d
Compare
Codecov Report
@@ Coverage Diff @@
## master #22574 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 169 169
Lines 50787 50787
=======================================
Hits 46745 46745
Misses 4042 4042
Continue to review full report at Codecov.
|
@@ -527,6 +527,7 @@ Removal of prior version deprecations/changes | |||
- Several private functions were removed from the (non-public) module ``pandas.core.common`` (:issue:`22001`) | |||
- Removal of the previously deprecated module ``pandas.core.datetools`` (:issue:`14105`, :issue:`14094`) | |||
- Strings passed into :meth:`DataFrame.groupby` that refer to both column and index levels will raise a ``ValueError`` (:issue:`14432`) | |||
- :meth:`Index.repeat` and :meth:`MultiIndex.repeat` have renamed the ``n`` argument to ``repeats``(:issue:`14645`) | |||
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n
is being removed though, not renamed? Maybe
:meth:
Index.repeat
and :meth:MultiIndex.repeat
have then
synonym to therepeats
argument removed (deprecated since v.0.20.0) ). (:issue:14645
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original argument was n
. Then we deprecated in favor of repeats
. Now we're permanently renaming it to repeats
. That's why it's described as such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way I see it is that in 0.20 n
was renamed and deprecated, and now the deprecated param n
is being removed...
Anyway, could just be a difference of perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, could just be a difference of perspective.
Agreed.
thanks! |
For Index and MultiIndex. xref pandas-devgh-14645.
For Index and MultiIndex. xref pandas-devgh-14645.
For
Index
andMultiIndex
.xref #14645.