Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Follows ISO 639-1 code #22657

Merged
merged 5 commits into from
Sep 30, 2018
Merged

Conversation

KangYoosam
Copy link
Contributor

@KangYoosam KangYoosam commented Sep 10, 2018

Changes

  • change suffix _JP to _JA according to ISO 639
  • fixed typo in Pandas_Cheat_Sheet_JA.pdf
  • translated Pandas_Cheat_Sheet_JA.pptx in Japanese

@TomAugspurger
Copy link
Contributor

What is this fixing / changing?

@KangYoosam
Copy link
Contributor Author

KangYoosam commented Sep 11, 2018

thanks @TomAugspurger .

Changes

  • change suffix _JP to _JA according to ISO 639
  • fixed typo in Pandas_Cheat_Sheet_JA.pdf
  • translated Pandas_Cheat_Sheet_JA.pptx in Japanese

I updated description.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know any Japanese but side by side diff looks ok AFAICT

@WillAyd WillAyd added the Docs label Sep 11, 2018
@TomAugspurger
Copy link
Contributor

Are these linked to anywhere on pandas.pydata.org? We'll need to put in a redirect on github.com/pandas-dev/pandas-website if so.

@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #22657 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22657   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         169      169           
  Lines       50708    50708           
=======================================
  Hits        46740    46740           
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.58% <ø> (ø) ⬆️
#single 42.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0976e12...d757f66. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Sep 15, 2018
@datapythonista
Copy link
Member

Seems like the Japanese cheatsheets are not linked anywhere. Merging the fixes, and we can take care of adding links in a separate PR.

Thanks for the PR @KangYoosam, and for taking care of the Japanese translation.

@datapythonista datapythonista merged commit 2f1b842 into pandas-dev:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants