Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST/CLN: remove duplicate data file used in tests (unicode_series.csv) #22723

Merged
merged 2 commits into from
Sep 18, 2018
Merged

TST/CLN: remove duplicate data file used in tests (unicode_series.csv) #22723

merged 2 commits into from
Sep 18, 2018

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Sep 15, 2018 •
edited
Loading

  • [N/A ] closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [ N/A] whatsnew entry

@pep8speaks
Copy link

Hello @simonjayhawkins! Thanks for submitting the PR.

@WillAyd
Copy link
Member

WillAyd commented Sep 15, 2018

Can you open an issue for this? Not entirely clear of the context

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Sep 15, 2018
WillAyd
WillAyd requested changes Sep 15, 2018
View reviewed changes
pandas/tests/io/conftest.py Outdated Show resolved Hide resolved
pandas/tests/io/parser/dtypes.py Outdated Show resolved Hide resolved
@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Sep 15, 2018 •
edited
Loading

@WillAyd

Can you open an issue for this? Not entirely clear of the context

there is no issue. context: just came across duplicate data file and thought it could be de-duplicated!

@simonjayhawkins simonjayhawkins changed the title TST/CLN: remove duplicate file and create filepath fixture (unicode_series.csv) TST/CLN: remove duplicate data file used in tests (unicode_series.csv) Sep 15, 2018
@TomAugspurger
Copy link
Contributor

Some context: previously, we had a function get_data_path that did some black magic to get the directory of the currently running test, so we had to duplicate files for each tree that needed the file :)

@simonjayhawkins did you notice any other duplicates?

WillAyd
WillAyd approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One Travis build timed out which I restarted. Another failed due to clipboard tests which I believe were resolved in #22715 so lgtm so long as the restart goes green

@jreback jreback added this to the 0.24.0 milestone Sep 18, 2018
@jreback jreback merged commit 712c8b1 into pandas-dev:master Sep 18, 2018
@jreback
Copy link
Contributor

jreback commented Sep 18, 2018

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the dup-test-data branch September 18, 2018 14:25
aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Sep 20, 2018
@simonjayhawkins @aeltanawy
TST/CLN: remove duplicate data file used in tests (unicode_series.csv) (
3ec461f 
pandas-dev#22723)
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@simonjayhawkins
TST/CLN: remove duplicate data file used in tests (unicode_series.csv) (
e32b255 
pandas-dev#22723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@simonjayhawkins @pep8speaks @WillAyd @TomAugspurger @jreback