CLN: Removes module pandas.json #22737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vitoriahmc! Thanks for submitting the PR.
|
|
Thanks. We'll also want a release note in doc/source/whatsnew/v0.24.0.txt under the "removal of prior version" section. Looks good otherwise. |
I've just updated it! |
|
thanks @vitoriahmc lib.py, parser.py, tslib.py are fair game as well |
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Sep 20, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffI'm just not sure about which file should I add my changes in whatsnew, can anyone help me with that?