Git version #22745
Merged
Git version #22745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @alimcmaster1! Thanks for submitting the PR.
|
jschendel
reviewed
Sep 18, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -185,7 +185,7 @@ Other Enhancements | |||
| - :class:`Resampler` now is iterable like :class:`GroupBy` (:issue:`15314`). | |||
| - :meth:`Series.resample` and :meth:`DataFrame.resample` have gained the :meth:`Resampler.quantile` (:issue:`15023`). | |||
| - :meth:`Index.to_frame` now supports overriding column name(s) (:issue:`22580`). | |||
|
|
|||
| - New attribute :attr:`__git_version__` will return git commit sha of current build (:issue:`21295` ). | |||
There was a problem hiding this comment.
small nitpick: extra space before the closing parenthesis in (:issue:`21295` )
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #22745 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 169 169
Lines 50769 50769
=======================================
Hits 46791 46791
Misses 3978 3978
Continue to review full report at Codecov.
|
Not that is matters, but if you use an [x] instead of [y] you get a tick mark.
|
|
LGTM, thanks! |
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Sep 20, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished off the work largely completed in this pull request: #21680
git diff upstream/master -u -- "*.py" | flake8 --diff