Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Reorders DataFrame.any and all docstrings to match function signature #22774

Merged

Conversation

jrbourbeau
Copy link
Contributor

@jrbourbeau jrbourbeau commented Sep 19, 2018

This PR updates the docstrings for DataFrame.any and DataFrame.all to match the corresponding function signatures. Specifically, the bool_only parameter was moved to be the seconds parameter in the docstring.

@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #22774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22774   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         169      169           
  Lines       50778    50778           
=======================================
  Hits        46807    46807           
  Misses       3971     3971
Flag Coverage Δ
#multiple 90.59% <ø> (ø) ⬆️
#single 42.33% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 96.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c113db...c844016. Read the comment docs.

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Sep 20, 2018
@TomAugspurger
Copy link
Contributor

Thanks! Verified locally that the updated docstring passes the validator.

@TomAugspurger TomAugspurger merged commit 32a74f1 into pandas-dev:master Sep 20, 2018
@jrbourbeau jrbourbeau deleted the update_dataframe_all_any_docstring branch September 20, 2018 15:55
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants