Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Avoid AmbiguousTime or NonExistentTime Error when resampling #22809

Merged
merged 2 commits into from
Sep 23, 2018

Conversation

mroeschke
Copy link
Member

@pep8speaks
Copy link

Hello @mroeschke! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Sep 22, 2018

Codecov Report

Merging #22809 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22809      +/-   ##
==========================================
+ Coverage   92.18%   92.18%   +<.01%     
==========================================
  Files         169      169              
  Lines       50810    50812       +2     
==========================================
+ Hits        46839    46842       +3     
+ Misses       3971     3970       -1
Flag Coverage Δ
#multiple 90.6% <100%> (ø) ⬆️
#single 42.37% <0%> (+0.04%) ⬆️
Impacted Files Coverage Δ
pandas/core/resample.py 96.97% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb7a16...acd9128. Read the comment docs.

@mroeschke mroeschke added this to the 0.24.0 milestone Sep 23, 2018
@jreback jreback added Bug Timezones Timezone data dtype Resample resample method labels Sep 23, 2018
@jreback jreback merged commit f65fa75 into pandas-dev:master Sep 23, 2018
@jreback
Copy link
Contributor

jreback commented Sep 23, 2018

thanks @mroeschke

@mroeschke mroeschke deleted the timezone_resample branch September 23, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Resample resample method Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NonExistentTimeError after Resample resample gives AmbiguousTimeError when index ends on a DST boundary
3 participants