-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to_flat_index method to MultiIndex #22866
Merged
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ccaea63
Added initial test
WillAyd c9b2629
Method implementation
WillAyd 36a74ce
Merge remote-tracking branch 'upstream/master' into mi-to-index
WillAyd 4774368
Merge remote-tracking branch 'upstream/master' into HEAD
WillAyd b7150bb
Stubbed out sep parameter
WillAyd d96f293
Documentation updates
WillAyd 7e651f7
Merge remote-tracking branch 'upstream/master' into mi-to-index
WillAyd b9c993c
Merge remote-tracking branch 'upstream/master' into mi-to-index
WillAyd 9e5a305
Moved to_index to base
WillAyd bc60292
Removed unused import
WillAyd 380595f
Returned identity instead of copy for non MI
WillAyd be06e7d
Fixed up docstring
WillAyd 4376bf6
Merge remote-tracking branch 'upstream/master' into mi-to-index
WillAyd 1ac6200
Changed method name; removed sep parameter
WillAyd f7a2342
Fixed broken test
WillAyd bea4e85
Moved to inheritance model
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idle style question (no need to change here): what are people's preferences on
isnstance
to figure out which one we're working withreturn self
, and overriding inMultiIndex
, so noif isintance
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preference for 2, and in general, for leaving the base
Index
class unaware (every time it is possible/reasonable) of the existence and specificities ofIndex
subclasses.