-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPAT: mpl 3.0 #22870
COMPAT: mpl 3.0 #22870
Conversation
Hello @TomAugspurger! Thanks for submitting the PR.
|
The test |
5fbffe4 was the original commit (6 years ago). Nothing in that looks like it depends on the number of points, just the freq, so I'm going to reduce the number to 100 (finishes in 0.5s locally with that). |
img = ax.collections[0] | ||
cbar = self.fig.colorbar(img, ax=ax, **kwds) | ||
|
||
if _mpl_ge_3_0_0(): | ||
# The workaround below is no longer necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could xfail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the plotting code itself, not in the test. The workaround is necessary for mpl < 3.0, but breaks things in mpl >= 3.0
yep |
Codecov Report
@@ Coverage Diff @@
## master #22870 +/- ##
==========================================
- Coverage 92.19% 92.18% -0.01%
==========================================
Files 169 169
Lines 50827 50830 +3
==========================================
Hits 46860 46860
- Misses 3967 3970 +3
Continue to review full report at Codecov.
|
Given that |
* COMPAT: mpl 3.0 * faster test
Closes #22790