Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Added explicit exceptions #22907

Merged
merged 7 commits into from
Oct 1, 2018
Merged

STYLE: Added explicit exceptions #22907

merged 7 commits into from
Oct 1, 2018

Conversation

NeuralFlux
Copy link
Contributor

@NeuralFlux NeuralFlux commented Sep 30, 2018 •
edited by jreback
Loading

Fixed the following bare excepts:

pandas/compat/pickle_compat.py:36:13: E722 do not use bare except'
pandas/compat/pickle_compat.py:47:13: E722 do not use bare except'
pandas/compat/pickle_compat.py:185:1: E722 do not use bare except'
pandas/compat/pickle_compat.py:213:5: E722 do not use bare except'
pandas/tseries/holiday.py:297:5: E722 do not use bare except'
pandas/tseries/holiday.py:429:9: E722 do not use bare except'
pandas/tseries/holiday.py:438:9: E722 do not use bare except'
pandas/util/_print_versions.py:24:9: E722 do not use bare except'
pandas/util/_print_versions.py:53:5: E722 do not use bare except'
pandas/util/_print_versions.py:111:9: E722 do not use bare except'
pandas/util/_validators.py:62:9: E722 do not use bare except'

@pep8speaks
Copy link

pep8speaks commented Sep 30, 2018 •
edited
Loading

Hello @NeuralFlux! Thanks for updating the PR.

Comment last updated on September 30, 2018 at 08:56 Hours UTC

@NeuralFlux NeuralFlux changed the title Added explicit exceptions #22877 STYLE: Added explicit exceptions Sep 30, 2018
datapythonista
datapythonista reviewed Sep 30, 2018
View reviewed changes
pandas/util/_print_versions.py Outdated
@@ -108,7 +108,7 @@ def show_versions(as_json=False):
mod = importlib.import_module(modname)
ver = ver_f(mod)
deps_blob.append((modname, ver))
except:
except ModuleNotFoundError:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. ModuleNotFoundError is Python 3 only, and unfortunately we need to support Python 2 few more months. Can you find a Python 2 compatible way for this please?

@datapythonista datapythonista added Error Reporting Incorrect or improved errors from pandas CI Continuous Integration Code Style Code style, linting, code_checks labels Sep 30, 2018
@NeuralFlux
Made compatible with Py2.7
87ea4d8 
Changed ModuleNotFoundError to ImportError
@codecov
Copy link

codecov bot commented Sep 30, 2018 •
edited
Loading

Codecov Report

Merging #22907 into master will not change coverage.
The diff coverage is 27.27%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22907   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50830    50830           
=======================================
  Hits        46860    46860           
  Misses       3970     3970
Flag Coverage Δ
#multiple 90.6% <27.27%> (ø) ⬆️
#single 42.37% <9.09%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/_print_versions.py 15.71% <0%> (ø) ⬆️
pandas/util/_validators.py 96.8% <0%> (ø) ⬆️
pandas/compat/pickle_compat.py 75.6% <25%> (ø) ⬆️
pandas/tseries/holiday.py 93.17% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14598c6...87ea4d8. Read the comment docs.

datapythonista
datapythonista approved these changes Sep 30, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @NeuralFlux, looks great. I think it's ready to be merged when the checks are green. @jreback

@NeuralFlux
Copy link
Contributor Author

Thank you so much @datapythonista ! Looking forward for those green checks!

@jreback jreback added this to the 0.24.0 milestone Oct 1, 2018
@jreback jreback merged commit 4226d74 into pandas-dev:master Oct 1, 2018
@jreback
Copy link
Contributor

jreback commented Oct 1, 2018

thanks @NeuralFlux

jorisvandenbossche pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@NeuralFlux @jorisvandenbossche
STYLE: Added explicit exceptions (pandas-dev#22907)
4a6ed2e
@NeuralFlux
Copy link
Contributor Author

thanks @NeuralFlux

My pleasure to help! Thank you for the good-first-issue! @jreback and @datapythonista

@datapythonista datapythonista mentioned this pull request Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Code Style Code style, linting, code_checks Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@NeuralFlux @pep8speaks @jreback @datapythonista