-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blank lines-->fix cookbook rendering issue #23144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23144 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 170 170
Lines 51073 51073
=======================================
Hits 47056 47056
Misses 4017 4017
Continue to review full report at Codecov.
|
what are you removing lines? if anything they improve code readability |
@jreback Yes I was removing lines. Ipython directive has a bug to cut off a function block if there is a blank line. Please let me know if there is another way to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to find a better way to fix the problem with the ipython directive, but unless someone knows how to do that, I think we can merge this, which is probably better than having the function incomplete (ipython only renders until the first blank line). See: https://pandas-docs.github.io/pandas-docs-travis/cookbook.html#correlation
better way is to use multiple ipython blocks (caveat is that they cannot span a single function definition) |
But can we split the code of a function across different ipython blocks? I'm thinking that may be a better option is to use a Closing this PR. @thoo do you want to take care of that? The idea is to use
|
@datapythonista Sure. Let me take a look. Hopefully it is straight forward. |
@datapythonista Will this work?
|
I think you need the |
Fixes #23128