Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN import from pandas.core.arrays when possible #23193

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

JustinZhengBC
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

pandas.core.arrays.__init__.py imports some classes by default, so other classes can import directly from pandas.core.arrays instead of accessing the specific files

@pep8speaks
Copy link

Hello @JustinZhengBC! Thanks for submitting the PR.

@jreback jreback added the Clean label Oct 17, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 17, 2018
@jreback
Copy link
Contributor

jreback commented Oct 17, 2018

lgtm. we can merge on green. (

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #23193 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23193   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50964    50964           
=======================================
  Hits        46985    46985           
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 42.29% <25%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 95.56% <100%> (ø) ⬆️
pandas/core/groupby/generic.py 87.06% <100%> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd863d3...9ccaf51. Read the comment docs.

@TomAugspurger
Copy link
Contributor

Green enough :)

Thanks @JustinZhengBC.

@TomAugspurger TomAugspurger merged commit d7d0ba2 into pandas-dev:master Oct 17, 2018
@TomAugspurger TomAugspurger mentioned this pull request Oct 17, 2018
2 tasks
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants