Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: bare-bones fixture for timedelta array tests #23207

Merged
merged 3 commits into from
Oct 19, 2018

Conversation

jbrockmendel
Copy link
Member

Broken off from #23140. The fixture needs to be fleshed out, but for now I just want to get it in place, since already other PRs need it.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #23207 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23207   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50950    50950           
=======================================
  Hits        46975    46975           
  Misses       3975     3975
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 42.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54e20b...87f970c. Read the comment docs.

@jreback jreback added Testing pandas testing functions or related to the test suite Timedelta Timedelta data type labels Oct 18, 2018
@jreback jreback merged commit b5e1fc2 into pandas-dev:master Oct 19, 2018
@jreback
Copy link
Contributor

jreback commented Oct 19, 2018

thanks!

@jbrockmendel jbrockmendel deleted the tdarr_tests branch October 23, 2018 03:28
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants