Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Quieter doctests #23232

Merged
merged 2 commits into from
Oct 19, 2018

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger added the CI Continuous Integration label Oct 18, 2018
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Oct 18, 2018
@TomAugspurger
Copy link
Contributor Author

Previously, lint failures were being pushed far away from the exit code due to a new line per doctest.

If there is a failure, it'll still be printed out.

inside ./ci/code_checks.sh
Doctests frame.py
.......................F...........................                                                                                                  [100%]
========================================================================= FAILURES =========================================================================
________________________________________________________ [doctest] pandas.core.frame.DataFrame.info ________________________________________________________
2199         DataFrame.memory_usage: Memory usage of DataFrame columns.
2200
2201         Examples
2202         --------
2203         >>> int_values = [1, 2, 3, 4, 5]
2204         >>> text_values = ['alpha', 'beta', 'gamma', 'delta', 'epsilon']
2205         >>> float_values = [0.0, 0.25, 0.5, 0.75, 1.0]
2206         >>> df = pd.DataFrame({"int_col": int_values, "text_col": text_values,
2207         ...                   "float_col": float_values})
2208         >>> df
Differences (unified diff with -expected +actual):
    @@ -1,3 +1,3 @@
    -   int_col text_col  float_co
    +   int_col text_col  float_col
     0        1    alpha       0.00
     1        2     beta       0.25

/Users/taugspurger/sandbox/pandas/pandas/core/frame.py:2208: DocTestFailure

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used that originally locally to see which ones were running/failing, but indeed on travis it is mainly important to see the error

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #23232 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23232   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50950    50950           
=======================================
  Hits        46975    46975           
  Misses       3975     3975
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 42.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54e20b...8efebf9. Read the comment docs.

@TomAugspurger TomAugspurger merged commit ecc5cbc into pandas-dev:master Oct 19, 2018
@TomAugspurger TomAugspurger deleted the quiet-doctest-modules branch October 19, 2018 02:02
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants