Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Added Examples for Series max #23298

Merged
merged 7 commits into from
Oct 25, 2018
Merged

DOC: Added Examples for Series max #23298

merged 7 commits into from
Oct 25, 2018

Conversation

vadakattu
Copy link
Contributor

@vadakattu vadakattu commented Oct 23, 2018 •
edited
Loading

  • tests passed locally (to the same extent as master)
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@pep8speaks
Copy link

Hello @vadakattu! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 23, 2018 •
edited
Loading

Codecov Report

Merging #23298 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23298      +/-   ##
==========================================
+ Coverage   92.22%   92.23%   +<.01%     
==========================================
  Files         169      169              
  Lines       50897    50925      +28     
==========================================
+ Hits        46940    46969      +29     
+ Misses       3957     3956       -1
Flag Coverage Δ
#multiple 90.65% <100%> (ø) ⬆️
#single 42.28% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 96.79% <100%> (-0.05%) ⬇️
pandas/core/internals/blocks.py 94.02% <0%> (-0.06%) ⬇️
pandas/core/indexes/multi.py 95.46% <0%> (ø) ⬆️
pandas/core/indexes/interval.py 94.65% <0%> (+0.01%) ⬆️
pandas/core/arrays/categorical.py 95.56% <0%> (+0.03%) ⬆️
pandas/core/arrays/datetimes.py 97.45% <0%> (+0.05%) ⬆️
pandas/core/arrays/interval.py 93.02% <0%> (+0.2%) ⬆️
pandas/util/testing.py 86.73% <0%> (+0.23%) ⬆️
pandas/core/arrays/integer.py 95.48% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0c91e...49b6330. Read the comment docs.

WillAyd
WillAyd requested changes Oct 25, 2018
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks pretty good save one typo

pandas/core/generic.py Outdated Show resolved Hide resolved
@WillAyd WillAyd added the Docs label Oct 25, 2018
@TomAugspurger
Copy link
Contributor

Small request. +1 to merge once that's fixed.

@vadakattu
Copy link
Contributor Author

Updated from_arrays to from_product as suggested by @datapythonista on #23279

@WillAyd WillAyd merged commit c76173b into pandas-dev:master Oct 25, 2018
@WillAyd
Copy link
Member

WillAyd commented Oct 25, 2018

Thanks @vadakattu !

@vadakattu vadakattu mentioned this pull request Oct 25, 2018
Merged
2 tasks
@vadakattu vadakattu deleted the series-max branch October 26, 2018 09:47
thoo added a commit to thoo/pandas that referenced this pull request Oct 27, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into Warning_prefix_pa…
cc5dc0f 
…ndas

* repo_org/master: (23 commits)
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
  fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302)
  BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317)
  TST: re-enable gbq tests (pandas-dev#23303)
  Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311)
  isort imports-io (pandas-dev#23332)
  DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279)
  REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
  DOC: Added Examples for Series max (pandas-dev#23298)
  API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644)
  BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291)
  ...
thoo added a commit to thoo/pandas that referenced this pull request Oct 27, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into check_np_pd_fromE…
881b011 
…xamples

* repo_org/master: (83 commits)
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
  fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302)
  BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317)
  TST: re-enable gbq tests (pandas-dev#23303)
  Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311)
  isort imports-io (pandas-dev#23332)
  DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279)
  REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
  DOC: Added Examples for Series max (pandas-dev#23298)
  API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644)
  BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@vadakattu @tm9k1
DOC: Added Examples for Series max (pandas-dev#23298)
b12f27d
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@vadakattu @Pingviinituutti
DOC: Added Examples for Series max (pandas-dev#23298)
b6db80a
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@vadakattu @Pingviinituutti
DOC: Added Examples for Series max (pandas-dev#23298)
9f56e15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadakattu @pep8speaks @TomAugspurger @WillAyd