Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Cleanup top-level pandas namespace #23380

Merged
merged 1 commit into from
Oct 28, 2018
Merged

CLN: Cleanup top-level pandas namespace #23380

merged 1 commit into from
Oct 28, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 27, 2018 •
edited
Loading

Drops the following:

  • pd.pnow
  • pd.match
  • pd.groupby
  • pd.get_store

As well as:

  • pd.Expr
  • pd.Term

xref #15538.
xref #15940.

@gfyoung
CLN: Cleanup top-level pandas namespace
67c908d 
Drops the following:

* pd.pnow
* pd.match
* pd.groupby
* pd.get_store

* pd.Expr
* pd.Term

xref pandas-devgh-15538.
xref pandas-devgh-15940.
@gfyoung gfyoung added API Design Deprecate Functionality to remove in pandas Clean labels Oct 27, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Oct 27, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@jreback jreback mentioned this pull request Oct 27, 2018
Closed
@codecov
Copy link

codecov bot commented Oct 27, 2018 •
edited
Loading

Codecov Report

Merging #23380 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23380      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         169      169              
  Lines       51261    51236      -25     
==========================================
- Hits        47277    47252      -25     
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.66% <100%> (-0.01%) ⬇️
#single 42.23% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/period.py 92.22% <ø> (-0.06%) ⬇️
pandas/io/pytables.py 92.43% <ø> (-0.01%) ⬇️
pandas/core/computation/api.py 100% <ø> (ø) ⬆️
pandas/io/api.py 100% <100%> (ø) ⬆️
pandas/core/api.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f662c5f...67c908d. Read the comment docs.

@jreback jreback merged commit 40423e3 into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

thanks @gfyoung

@gfyoung gfyoung deleted the pd-namespace-clean branch October 28, 2018 05:20
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@gfyoung @tm9k1
CLN: Cleanup top-level pandas namespace (pandas-dev#23380)
9652fc9 
Drops the following:

* pd.pnow
* pd.match
* pd.groupby
* pd.get_store

* pd.Expr
* pd.Term

xref pandas-devgh-15538.
xref pandas-devgh-15940.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Cleanup top-level pandas namespace (pandas-dev#23380)
4816601 
Drops the following:

* pd.pnow
* pd.match
* pd.groupby
* pd.get_store

* pd.Expr
* pd.Term

xref pandas-devgh-15538.
xref pandas-devgh-15940.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Cleanup top-level pandas namespace (pandas-dev#23380)
a108c76 
Drops the following:

* pd.pnow
* pd.match
* pd.groupby
* pd.get_store

* pd.Expr
* pd.Term

xref pandas-devgh-15538.
xref pandas-devgh-15940.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Design Clean Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gfyoung @pep8speaks @jreback