-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: fix import format at pandas/core/computation #23388
Conversation
Hello @streeck! Thanks for submitting the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
pandas/core/computation/scope.py:50: in
'Timestamp': pandas._libs.tslib.Timestamp,
E NameError: name 'pandas' is not defined
We seem to have removed some required imports here. Please can you run code_checks locally and see if you can fix
Yeah, removing the |
can you merge master, we just updated the isort cfg |
can you merge master and update |
Will do later today + the fix |
Also fix pandas removed import usage to pd
Codecov Report
@@ Coverage Diff @@
## master #23388 +/- ##
==========================================
- Coverage 92.21% 92.21% -0.01%
==========================================
Files 161 161
Lines 51173 51169 -4
==========================================
- Hits 47190 47186 -4
Misses 3983 3983
Continue to review full report at Codecov.
|
thanks ! |
git diff master -u -- "*.py" | flake8 --diff