Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix import format at pandas/core/computation #23388

Merged
merged 3 commits into from
Nov 1, 2018
Merged

style: fix import format at pandas/core/computation #23388

merged 3 commits into from
Nov 1, 2018

Conversation

streeck
Copy link
Contributor

@streeck streeck commented Oct 27, 2018

@pep8speaks
Copy link

Hello @streeck! Thanks for submitting the PR.

@gfyoung gfyoung added the Code Style Code style, linting, code_checks label Oct 27, 2018
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

pandas/core/computation/scope.py:50: in
'Timestamp': pandas._libs.tslib.Timestamp,
E NameError: name 'pandas' is not defined

We seem to have removed some required imports here. Please can you run code_checks locally and see if you can fix

@streeck
Copy link
Contributor Author

streeck commented Oct 29, 2018

Yeah, removing the import pandas broke line 50, should I add the import back or change line 50 to use pd since there's already an import pandas as pd? @alimcmaster1
Edit: forgot to mention that changing line 50 to: 'Timestamp': pd._libs.tslib.Timestamp works (locally tested)

@jreback
Copy link
Contributor

jreback commented Oct 29, 2018

can you merge master, we just updated the isort cfg

@jreback
Copy link
Contributor

jreback commented Oct 30, 2018

can you merge master and update

@streeck
Copy link
Contributor Author

streeck commented Oct 30, 2018

Will do later today + the fix

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #23388 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23388      +/-   ##
==========================================
- Coverage   92.21%   92.21%   -0.01%     
==========================================
  Files         161      161              
  Lines       51173    51169       -4     
==========================================
- Hits        47190    47186       -4     
  Misses       3983     3983
Flag Coverage Δ
#multiple 90.65% <100%> (-0.01%) ⬇️
#single 42.23% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/computation/expressions.py 93.27% <ø> (ø) ⬆️
pandas/core/computation/eval.py 97.11% <100%> (ø) ⬆️
pandas/core/computation/expr.py 88.57% <100%> (-0.09%) ⬇️
pandas/core/computation/engines.py 88.88% <100%> (ø) ⬆️
pandas/core/computation/ops.py 95.6% <100%> (ø) ⬆️
pandas/core/computation/scope.py 93.06% <100%> (-0.07%) ⬇️
pandas/core/computation/pytables.py 92.37% <100%> (ø) ⬆️
pandas/core/computation/common.py 85.71% <100%> (ø) ⬆️
pandas/core/computation/align.py 97.89% <100%> (ø) ⬆️
pandas/core/computation/check.py 90.9% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de39bfc...d341a12. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Nov 1, 2018
@jreback jreback merged commit a907814 into pandas-dev:master Nov 1, 2018
@jreback
Copy link
Contributor

jreback commented Nov 1, 2018

thanks !

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants