-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix format of the See Also descriptions #23654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this @syutbai, looks great.
I'm not sure if git will be able to merge automatically the changes to the titles, as they are the same exact change. I'd wait until we have the conflict, in case it's not needed.
Looks like git manages the merge ok. @syutbai can you fix the linting errors on travis, so we can merge:
|
@datapythonista Sorry for the tabbing issues. I pushed the changes to my branch. Do I need to do another pull request or are we good for merge now? Thanks! |
Updating the branch is good enough, no need to open a new PR. I see travis is still red, can you take a look and see what is wrong? I'm in my phone and can't check myself right now. |
I see the following error but the script ends with 0:
The other script ends with exit code 1 but I'm unable to tell where the error is:
|
The line causing the failure is at https://travis-ci.org/pandas-dev/pandas/jobs/454288173#L2823 |
not sure about why the errors you posted aren't failing the build, but @datapythonista will look at that separately I think. |
pandas/core/frame.py
Outdated
pandas.io.stata.StataWriter117 : low-level writer for version 117 files | ||
pandas.read_stata : Import Stata data files. | ||
pandas.io.stata.StataWriter : Low-level writer for Stata data files. | ||
pandas.io.stata.StataWriter117 : Low-level writer for version 117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pandas.io.stata.StataWriter117 : Low-level writer for version 117 | |
pandas.io.stata.StataWriter117 : Low-level writer for version 117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a code suggestion removing the whitespace, so you should be able to fix it with a single click.
The error you shown is not really a test error. Is the output of a docstring validation that is being printed (need to check why, as it shouldn't). But that's not really a test failing, is just a "debug" information.
I pushed the change. How did you identify the file and line number with the issue? |
Restarted the failing travis build. Not sure what's up with it. |
Codecov Report
@@ Coverage Diff @@
## master #23654 +/- ##
==========================================
+ Coverage 92.24% 92.24% +<.01%
==========================================
Files 161 161
Lines 51317 51318 +1
==========================================
+ Hits 47338 47339 +1
Misses 3979 3979
Continue to review full report at Codecov.
|
All green. Thanks @syutbai! |
The exact error was in the travis log. But it's difficult to see if you're not used to it. We're workingon making the errors much clearer in the CI, hopefully that will be deployed soon. |
* upstream/master: (25 commits) DOC: Delete trailing blank lines in docstrings. (pandas-dev#23651) DOC: Change release and whatsnew (pandas-dev#21599) DOC: Fix format of the See Also descriptions (pandas-dev#23654) DOC: update pandas.core.groupby.DataFrameGroupBy.resample docstring. (pandas-dev#20374) ENH: Allow export of mixed columns to Stata strl (pandas-dev#23692) CLN: Remove unnecessary code (pandas-dev#23696) Pin flake8-rst version (pandas-dev#23699) Implement _most_ of the EA interface for DTA/TDA (pandas-dev#23643) CI: raise clone depth limit on CI BUG: Fix Series/DataFrame.rank(pct=True) with more than 2**24 rows (pandas-dev#23688) REF: Move Excel names parameter handling to CSV (pandas-dev#23690) DOC: Accessing files from a S3 bucket. (pandas-dev#23639) Fix errorbar visualization (pandas-dev#23674) DOC: Surface / doc mangle_dupe_cols in read_excel (pandas-dev#23678) DOC: Update is_sparse docstring (pandas-dev#19983) BUG: Fix read_excel w/parse_cols & empty dataset (pandas-dev#23661) Add to_flat_index method to MultiIndex (pandas-dev#22866) CLN: Move to_excel to generic.py (pandas-dev#23656) TST: IntervalTree.get_loc_interval should return platform int (pandas-dev#23660) CI: Allow to compile docs with ipython 7.11 pandas-dev#22990 (pandas-dev#23655) ...
…fixed * upstream/master: DOC: Delete trailing blank lines in docstrings. (pandas-dev#23651) DOC: Change release and whatsnew (pandas-dev#21599) DOC: Fix format of the See Also descriptions (pandas-dev#23654) DOC: update pandas.core.groupby.DataFrameGroupBy.resample docstring. (pandas-dev#20374) ENH: Allow export of mixed columns to Stata strl (pandas-dev#23692) CLN: Remove unnecessary code (pandas-dev#23696) Pin flake8-rst version (pandas-dev#23699) Implement _most_ of the EA interface for DTA/TDA (pandas-dev#23643) CI: raise clone depth limit on CI BUG: Fix Series/DataFrame.rank(pct=True) with more than 2**24 rows (pandas-dev#23688) REF: Move Excel names parameter handling to CSV (pandas-dev#23690) DOC: Accessing files from a S3 bucket. (pandas-dev#23639) Fix errorbar visualization (pandas-dev#23674) DOC: Surface / doc mangle_dupe_cols in read_excel (pandas-dev#23678) DOC: Update is_sparse docstring (pandas-dev#19983) BUG: Fix read_excel w/parse_cols & empty dataset (pandas-dev#23661) Add to_flat_index method to MultiIndex (pandas-dev#22866) CLN: Move to_excel to generic.py (pandas-dev#23656) TST: IntervalTree.get_loc_interval should return platform int (pandas-dev#23660)
* pandas refs 23630, partial.
* pandas refs 23630, partial.
* pandas refs 23630, partial.
git diff upstream/master -u -- "*.py" | flake8 --diff