Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix format of the See Also descriptions #23654

Merged
merged 3 commits into from
Nov 14, 2018

Conversation

syutbai
Copy link
Contributor

@syutbai syutbai commented Nov 12, 2018

@TomAugspurger
Copy link
Contributor

Hmm @gueletk also has the "See Also" changes in #23653

@syutbai would it be hard for you to revert those changes, so that there isn't a merge conflict?

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this @syutbai, looks great.

I'm not sure if git will be able to merge automatically the changes to the titles, as they are the same exact change. I'd wait until we have the conflict, in case it's not needed.

@datapythonista datapythonista changed the title DOC: pandas refs 23630, partial. Fix format of the See Also descriptions DOC: Fix format of the See Also descriptions Nov 12, 2018
@datapythonista datapythonista added Docs CI Continuous Integration Clean labels Nov 12, 2018
@datapythonista
Copy link
Member

Looks like git manages the merge ok.

@syutbai can you fix the linting errors on travis, so we can merge:

./pandas/core/frame.py:354:5: W191 indentation contains tabs
./pandas/core/frame.py:354:5: E101 indentation contains mixed spaces and tabs
./pandas/core/frame.py:1923:80: E501 line too long (80 > 79 characters)

@syutbai
Copy link
Contributor Author

syutbai commented Nov 13, 2018

@datapythonista Sorry for the tabbing issues. I pushed the changes to my branch. Do I need to do another pull request or are we good for merge now? Thanks!

@datapythonista
Copy link
Member

Updating the branch is good enough, no need to open a new PR.

I see travis is still red, can you take a look and see what is wrong? I'm in my phone and can't check myself right now.

@syutbai
Copy link
Contributor Author

syutbai commented Nov 13, 2018

I see the following error but the script ends with 0:

3 Errors found:
	err desc
	err desc
	err desc
.docstring1: err desc
docstring1: err desc
docstring1: err desc
docstring2: err desc
docstring2: err desc
..EXECUTED
{"docstring1": {"errors": [["ER01", "err desc"], ["ER02", "err desc"], ["ER03", "err desc"]]}, "docstring2": {"errors": [["ER04", "err desc"], ["ER05", "err desc"]]}}.Series.foo: err desc
DataFrame.bar: err desc
Series.foobar: err desc
Series.foo: err desc

=============== 75 passed, 4 xfailed, 5 warnings in 3.48 seconds ===============
The command "ci/script_single.sh" exited with 0.

The other script ends with exit code 1 but I'm unable to tell where the error is:

=================== 5 passed, 12 deselected in 0.04 seconds ====================
Doctests interval classes DONE
Check that requirements-dev.txt has been generated from environment.yml
Check that requirements-dev.txt has been generated from environment.yml DONE
The command "ci/code_checks.sh" exited with 1

@TomAugspurger
Copy link
Contributor

The line causing the failure is at https://travis-ci.org/pandas-dev/pandas/jobs/454288173#L2823

@TomAugspurger
Copy link
Contributor

./pandas/core/frame.py:1923:74: W291 trailing whitespace

not sure about why the errors you posted aren't failing the build, but @datapythonista will look at that separately I think.

pandas.io.stata.StataWriter117 : low-level writer for version 117 files
pandas.read_stata : Import Stata data files.
pandas.io.stata.StataWriter : Low-level writer for Stata data files.
pandas.io.stata.StataWriter117 : Low-level writer for version 117
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pandas.io.stata.StataWriter117 : Low-level writer for version 117
pandas.io.stata.StataWriter117 : Low-level writer for version 117

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a code suggestion removing the whitespace, so you should be able to fix it with a single click.

The error you shown is not really a test error. Is the output of a docstring validation that is being printed (need to check why, as it shouldn't). But that's not really a test failing, is just a "debug" information.

@syutbai
Copy link
Contributor Author

syutbai commented Nov 14, 2018

I pushed the change.

How did you identify the file and line number with the issue?

@TomAugspurger
Copy link
Contributor

Restarted the failing travis build. Not sure what's up with it.

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #23654 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23654      +/-   ##
==========================================
+ Coverage   92.24%   92.24%   +<.01%     
==========================================
  Files         161      161              
  Lines       51317    51318       +1     
==========================================
+ Hits        47338    47339       +1     
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 42.31% <63.63%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/json/table_schema.py 98.29% <ø> (ø) ⬆️
pandas/util/_validators.py 96.8% <ø> (ø) ⬆️
pandas/core/base.py 97.61% <ø> (ø) ⬆️
pandas/core/arrays/datetimes.py 98.44% <ø> (ø) ⬆️
pandas/plotting/_core.py 83.63% <ø> (ø) ⬆️
pandas/core/arrays/period.py 98.49% <ø> (ø) ⬆️
pandas/core/indexes/period.py 93.04% <ø> (ø) ⬆️
pandas/core/groupby/groupby.py 96.51% <ø> (ø) ⬆️
pandas/core/arrays/categorical.py 95.34% <ø> (ø) ⬆️
pandas/core/indexes/numeric.py 97.32% <ø> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08bf3d...68050f7. Read the comment docs.

@TomAugspurger
Copy link
Contributor

All green. Thanks @syutbai!

@TomAugspurger TomAugspurger merged commit 6d031f2 into pandas-dev:master Nov 14, 2018
@datapythonista
Copy link
Member

The exact error was in the travis log. But it's difficult to see if you're not used to it. We're workingon making the errors much clearer in the CI, hopefully that will be deployed soon.

thoo added a commit to thoo/pandas that referenced this pull request Nov 15, 2018
* upstream/master: (25 commits)
  DOC: Delete trailing blank lines in docstrings. (pandas-dev#23651)
  DOC: Change release and whatsnew (pandas-dev#21599)
  DOC: Fix format of the See Also descriptions (pandas-dev#23654)
  DOC: update pandas.core.groupby.DataFrameGroupBy.resample docstring. (pandas-dev#20374)
  ENH: Allow export of mixed columns to Stata strl (pandas-dev#23692)
  CLN: Remove unnecessary code (pandas-dev#23696)
  Pin flake8-rst version (pandas-dev#23699)
  Implement _most_ of the EA interface for DTA/TDA (pandas-dev#23643)
  CI: raise clone depth limit on CI
  BUG: Fix Series/DataFrame.rank(pct=True) with more than 2**24 rows (pandas-dev#23688)
  REF: Move Excel names parameter handling to CSV (pandas-dev#23690)
  DOC: Accessing files from a S3 bucket. (pandas-dev#23639)
  Fix errorbar visualization (pandas-dev#23674)
  DOC: Surface / doc mangle_dupe_cols in read_excel (pandas-dev#23678)
  DOC: Update is_sparse docstring (pandas-dev#19983)
  BUG: Fix read_excel w/parse_cols & empty dataset (pandas-dev#23661)
  Add to_flat_index method to MultiIndex (pandas-dev#22866)
  CLN: Move to_excel to generic.py (pandas-dev#23656)
  TST: IntervalTree.get_loc_interval should return platform int (pandas-dev#23660)
  CI: Allow to compile docs with ipython 7.11 pandas-dev#22990 (pandas-dev#23655)
  ...
thoo added a commit to thoo/pandas that referenced this pull request Nov 15, 2018
…fixed

* upstream/master:
  DOC: Delete trailing blank lines in docstrings. (pandas-dev#23651)
  DOC: Change release and whatsnew (pandas-dev#21599)
  DOC: Fix format of the See Also descriptions (pandas-dev#23654)
  DOC: update pandas.core.groupby.DataFrameGroupBy.resample docstring. (pandas-dev#20374)
  ENH: Allow export of mixed columns to Stata strl (pandas-dev#23692)
  CLN: Remove unnecessary code (pandas-dev#23696)
  Pin flake8-rst version (pandas-dev#23699)
  Implement _most_ of the EA interface for DTA/TDA (pandas-dev#23643)
  CI: raise clone depth limit on CI
  BUG: Fix Series/DataFrame.rank(pct=True) with more than 2**24 rows (pandas-dev#23688)
  REF: Move Excel names parameter handling to CSV (pandas-dev#23690)
  DOC: Accessing files from a S3 bucket. (pandas-dev#23639)
  Fix errorbar visualization (pandas-dev#23674)
  DOC: Surface / doc mangle_dupe_cols in read_excel (pandas-dev#23678)
  DOC: Update is_sparse docstring (pandas-dev#19983)
  BUG: Fix read_excel w/parse_cols & empty dataset (pandas-dev#23661)
  Add to_flat_index method to MultiIndex (pandas-dev#22866)
  CLN: Move to_excel to generic.py (pandas-dev#23656)
  TST: IntervalTree.get_loc_interval should return platform int (pandas-dev#23660)
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Clean Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants