API: rename MultiIndex.labels to MultiIndex.codes #23752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
MultiIndex.codes
branch
6 times, most recently
from
135a58f
to
cf4060e
Compare
gfyoung
reviewed
Nov 18, 2018
gfyoung
reviewed
Nov 18, 2018
topper-123
force-pushed
the
MultiIndex.codes
branch
6 times, most recently
from
867c24c
to
fc2c214
Compare
Codecov Report
@@ Coverage Diff @@
## master #23752 +/- ##
==========================================
+ Coverage 92.2% 92.2% +<.01%
==========================================
Files 162 162
Lines 51714 51724 +10
==========================================
+ Hits 47682 47692 +10
Misses 4032 4032
Continue to review full report at Codecov.
|
jreback
requested changes
Nov 18, 2018
1 task
topper-123
force-pushed
the
MultiIndex.codes
branch
2 times, most recently
from
ad4b1cb
to
e1f83db
Compare
|
I've updated now. The Travis failure is unrelated (it's a unrelated test that consumes too much memory): I've also caught/done a few more renames, see latest commit. I'll start up updating the docs tonight or tomorrow. I'll do the doc changes in a seperate PR, as the current PR already is very large. |
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Nov 21, 2018
topper-123
force-pushed
the
MultiIndex.codes
branch
2 times, most recently
from
6f741ee
to
ae3877b
Compare
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Nov 22, 2018
topper-123
force-pushed
the
MultiIndex.codes
branch
from
ae3877b
to
c904825
Compare
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Nov 24, 2018
topper-123
force-pushed
the
MultiIndex.codes
branch
from
56a7bb5
to
a8d00ad
Compare
jreback
approved these changes
Dec 5, 2018
|
thanks @topper-123 nice change! |
|
Thanks a lot for this @topper-123 ! |
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 6, 2018
commit 28c61d770f6dfca6857fd0fa6979d4119a31129e
Author: Tom Augspurger <tom.w.augspurger@gmail.com>
Date: Thu Dec 6 12:18:19 2018 -0600
uncomment
commit bae2e322523efc73a1344464f51611e2dc555ccb
Author: Tom Augspurger <tom.w.augspurger@gmail.com>
Date: Thu Dec 6 12:17:09 2018 -0600
maybe fixes
commit 6cb4db05c9d6ceba3794096f0172cae5ed5f6019
Author: Tom Augspurger <tom.w.augspurger@gmail.com>
Date: Thu Dec 6 09:57:37 2018 -0600
we back
commit d97ab57fb32cb23371169d9ed659ccfac34cfe45
Merge: a117de4 b78aa8d
Author: Tom Augspurger <tom.w.augspurger@gmail.com>
Date: Thu Dec 6 09:51:51 2018 -0600
Merge remote-tracking branch 'upstream/master' into disown-tz-only-rebased2
commit b78aa8d
Author: gfyoung <gfyoung17+GitHub@gmail.com>
Date: Thu Dec 6 07:18:44 2018 -0500
REF/TST: Add pytest idiom to reshape/test_tile (pandas-dev#24107)
commit 2993b8e
Author: gfyoung <gfyoung17+GitHub@gmail.com>
Date: Thu Dec 6 07:17:55 2018 -0500
REF/TST: Add more pytest idiom to scalar/test_nat (pandas-dev#24120)
commit b841374
Author: evangelineliu <hsiyinliu@gmail.com>
Date: Wed Dec 5 18:21:46 2018 -0500
BUG: Fix concat series loss of timezone (pandas-dev#24027)
commit 4ae63aa
Author: jbrockmendel <jbrockmendel@gmail.com>
Date: Wed Dec 5 14:44:50 2018 -0800
Implement DatetimeArray._from_sequence (pandas-dev#24074)
commit 2643721
Author: jbrockmendel <jbrockmendel@gmail.com>
Date: Wed Dec 5 14:43:45 2018 -0800
CLN: Follow-up to pandas-dev#24100 (pandas-dev#24116)
commit 8ea7744
Author: chris-b1 <cbartak@gmail.com>
Date: Wed Dec 5 14:21:23 2018 -0600
PERF: ascii c string functions (pandas-dev#23981)
commit cb862e4
Author: jbrockmendel <jbrockmendel@gmail.com>
Date: Wed Dec 5 12:19:46 2018 -0800
BUG: fix mutation of DTI backing Series/DataFrame (pandas-dev#24096)
commit aead29b
Author: topper-123 <contribute@tensortable.com>
Date: Wed Dec 5 19:06:00 2018 +0000
API: rename MultiIndex.labels to MultiIndex.codes (pandas-dev#23752)
|
There are still a bunch of warnings in the docs that should be fixed: |
|
Ah, they all seem to come from parquet / feather. Will report upstream. |
|
There are some other in the whatsnew files as well |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
andrewsanchez
added a commit
to andrewsanchez/q2-diversity
that referenced
this pull request
Feb 12, 2020
Please see these links for the rational if interested: pandas-dev/pandas#13443 pandas-dev/pandas#23752
nbokulich
pushed a commit
to qiime2/q2-diversity
that referenced
this pull request
Feb 14, 2020
* Use MultiIndex.codes instead of labels (no longer support) Please see these links for the rational if interested: pandas-dev/pandas#13443 pandas-dev/pandas#23752 * Unpack and name values returned by _reindex_with_metadata This makes it easier to see what's going on below with the values returned by this function. * Initial patch to handle new pandas error This prevents attempting to drop columns that don't exist in merged.columns after setting the index, while still dropping columns that are present in merged.columns. Attempting to do so raises an exception in pandas >= 1. Please see pandas-dev/pandas#8594 for details. * Avoid mutating `merged` in place by assigning to new variable This avoids attempting to drop columns that had already been dropped in previous calls to _reindex_with_metadata in the for loop in `alpha_rarefaction`. Co-authored-by: Matthew Dillon <matthewrdillon@gmail.com> Co-authored-by: Matthew Dillon <matthewrdillon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThis PR renames
MultiIndex.labelstoMultiIndex.codes.Also note that I've not changed the repr method or the repr output in various doc strings examples in anticipation of #22511 (this would be unneeded extra work). This should all be ok when #22511 is merged.
I would appreciate comments on the changes quickly, as this is a very large PR that touches on many parts of pandas, so it quickly gets out of sync.
@jorisvandenbossche?