-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix flake8 issues in doc/source/reshaping.rst #24183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24183 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 162 162
Lines 51723 51723
=======================================
Hits 47695 47695
Misses 4028 4028
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24183 +/- ##
==========================================
- Coverage 92.21% 92.21% -0.01%
==========================================
Files 162 162
Lines 51723 51723
==========================================
- Hits 47695 47694 -1
- Misses 4028 4029 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
you'll have to merge the conflict in setup.cfg
, we just merged a PR removing some other files from the exclude list
12a447e
to
f555492
Compare
@datapythonista thanks, just rebased... |
@charlesdong1991 can you delete the |
oh, @datapythonista sorry, i didn't check very carefully... just recalled that they were in between |
No worries, usually conflicts are about code added or modified, but when the code is deleted, the fix is usually removing the code block. It usually helps to do a |
can you merge master here |
thanks! |
@datapythonista sorry, i was working and didn't notice the email... and many thanks for solving the merge conflict for me... |
no worries, these trivial conflicts can be easily fixed in the github UI |
git diff upstream/master -u -- "*.py" | flake8 --diff