Implement unique+array parts of 24024 #24527
Conversation
|
|
||
| * Categorical | ||
| * Period | ||
| * Datetime with Timezone |
There was a problem hiding this comment.
will edit. note otherwise this is verbatim from 24024
Codecov Report
@@ Coverage Diff @@
## master #24527 +/- ##
==========================================
- Coverage 31.88% 31.88% -0.01%
==========================================
Files 166 166
Lines 52413 52419 +6
==========================================
Hits 16714 16714
- Misses 35699 35705 +6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24527 +/- ##
==========================================
- Coverage 31.88% 31.88% -0.01%
==========================================
Files 166 166
Lines 52413 52419 +6
==========================================
Hits 16714 16714
- Misses 35699 35705 +6
Continue to review full report at Codecov.
|
| orig._values.astype(object).values) | ||
|
|
||
| # TODO(#24024) once orig._values returns DTA, remove | ||
| # the `._eadata` below |
There was a problem hiding this comment.
in future, can make this a proper form test (e.g. result =, expected = )
| @@ -431,7 +441,7 @@ def test_value_counts_unique_nunique_null(self): | |||
| o = klass(values.repeat(range(1, len(o) + 1))) | |||
| o.name = 'a' | |||
| else: | |||
| if is_datetime64tz_dtype(o): | |||
| if isinstance(o, DatetimeIndex): | |||
| expected_index = orig._values._shallow_copy(values) | |||
There was a problem hiding this comment.
these are super-hacks, in future, let's try to remove
|
thanks |
* upstream/master: BUG: output formatting with to_html(), index=False and/or index_names=False (pandas-dev#22579, pandas-dev#22747) (pandas-dev#22655) MAINT: Port _timelex in codebase (pandas-dev#24520) Implement unique+array parts of 24024 (pandas-dev#24527) Integer NA docs (pandas-dev#23617)
They have tests that go with them and are reasonably self-contained.