Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF/TST: Add more pytest idiom to test_to_html.py #24609

Merged
merged 2 commits into from
Jan 4, 2019

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@jreback jreback added Testing pandas testing functions or related to the test suite IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Jan 4, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 4, 2019
@jreback
Copy link
Contributor

jreback commented Jan 4, 2019

lgtm. ping on green.

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #24609 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24609      +/-   ##
==========================================
+ Coverage   92.38%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52490    52490              
==========================================
+ Hits        48493    48494       +1     
+ Misses       3997     3996       -1
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 43.05% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6249355...b857a02. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #24609 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24609      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52490    52471      -19     
==========================================
- Hits        48493    48471      -22     
- Misses       3997     4000       +3
Flag Coverage Δ
#multiple 90.8% <ø> (-0.02%) ⬇️
#single 43.06% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 94.21% <0%> (-0.33%) ⬇️
pandas/core/indexes/datetimelike.py 98.53% <0%> (-0.31%) ⬇️
pandas/core/nanops.py 94.36% <0%> (-0.19%) ⬇️
pandas/core/arrays/categorical.py 95.41% <0%> (-0.06%) ⬇️
pandas/core/indexes/category.py 98.61% <0%> (-0.04%) ⬇️
pandas/core/internals/__init__.py 100% <0%> (ø) ⬆️
pandas/core/series.py 93.56% <0%> (+0.02%) ⬆️
pandas/core/internals/managers.py 96.05% <0%> (+0.08%) ⬆️
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️
pandas/core/arrays/timedeltas.py 88.18% <0%> (+0.19%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6249355...870f4c7. Read the comment docs.

assert expected in result


def test_display_option_warning():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandas/tests/io/formats/test_to_html.py(244,): error :  Found unwanted pattern:     with pytest.warns(FutureWarning, match=msg)
Bash exited with code '1'.

use assert_produces_warning

@jreback jreback merged commit a42c9be into pandas-dev:master Jan 4, 2019
@jreback
Copy link
Contributor

jreback commented Jan 4, 2019

thanks!

@simonjayhawkins simonjayhawkins deleted the test-to-html branch January 4, 2019 17:41
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants