Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do freq validation in DTA.__init__ #24686

Merged
merged 4 commits into from
Jan 10, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 9, 2019

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #24686 into master will decrease coverage by 49.3%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24686       +/-   ##
===========================================
- Coverage   92.38%   43.08%   -49.31%     
===========================================
  Files         166      166               
  Lines       52310    52320       +10     
===========================================
- Hits        48327    22541    -25786     
- Misses       3983    29779    +25796
Flag Coverage Δ
#multiple ?
#single 43.08% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/datetimes.py 66.61% <100%> (-31.11%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.35%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update decc8ce...2e1b625. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #24686 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24686      +/-   ##
==========================================
+ Coverage   92.38%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52310    52320      +10     
==========================================
+ Hits        48327    48337      +10     
  Misses       3983     3983
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43.06% <92.85%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 97.67% <100%> (ø) ⬆️
pandas/core/internals/blocks.py 94.3% <100%> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.75% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update decc8ce...f63e32d. Read the comment docs.

@jreback jreback added Datetime Datetime data dtype ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 9, 2019
@jbrockmendel
Copy link
Member Author

gentle ping; this should go in before the RC

@jreback jreback added this to the 0.24.0 milestone Jan 10, 2019
@jreback
Copy link
Contributor

jreback commented Jan 10, 2019

lgtm. @TomAugspurger

@TomAugspurger TomAugspurger merged commit d46d2a5 into pandas-dev:master Jan 10, 2019
@TomAugspurger
Copy link
Contributor

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the dta branch January 10, 2019 23:04
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* do freq validation in DTA.__init__

* troubleshoot parquet fail

* troubleshoot feather

* troubleshoot pyarrow fail
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* do freq validation in DTA.__init__

* troubleshoot parquet fail

* troubleshoot feather

* troubleshoot pyarrow fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants