-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do freq validation in DTA.__init__ #24686
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24686 +/- ##
===========================================
- Coverage 92.38% 43.08% -49.31%
===========================================
Files 166 166
Lines 52310 52320 +10
===========================================
- Hits 48327 22541 -25786
- Misses 3983 29779 +25796
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24686 +/- ##
==========================================
+ Coverage 92.38% 92.38% +<.01%
==========================================
Files 166 166
Lines 52310 52320 +10
==========================================
+ Hits 48327 48337 +10
Misses 3983 3983
Continue to review full report at Codecov.
|
gentle ping; this should go in before the RC |
lgtm. @TomAugspurger |
Thanks @jbrockmendel |
* do freq validation in DTA.__init__ * troubleshoot parquet fail * troubleshoot feather * troubleshoot pyarrow fail
* do freq validation in DTA.__init__ * troubleshoot parquet fail * troubleshoot feather * troubleshoot pyarrow fail
git diff upstream/master -u -- "*.py" | flake8 --diff