Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/REF: Collect Reduction, Arithmetic Tests #24776

Merged
merged 4 commits into from
Jan 16, 2019

Conversation

jbrockmendel
Copy link
Member

Remove unused attributes in test_nanops

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #24776 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24776      +/-   ##
==========================================
- Coverage   92.38%   92.38%   -0.01%     
==========================================
  Files         166      166              
  Lines       52363    52363              
==========================================
- Hits        48377    48376       -1     
- Misses       3986     3987       +1
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 88% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3565a...c3749a2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #24776 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24776      +/-   ##
==========================================
- Coverage   92.38%   92.38%   -0.01%     
==========================================
  Files         166      166              
  Lines       52363    52363              
==========================================
- Hits        48377    48376       -1     
- Misses       3986     3987       +1
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 88% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3565a...c3749a2. Read the comment docs.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are all just moves?

pandas/tests/test_nanops.py Show resolved Hide resolved
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jan 16, 2019
@jbrockmendel
Copy link
Member Author

these are all just moves?

In some places I think I changed pytest.raises to use the context syntax. No material changes.

@jreback jreback added this to the 0.24.0 milestone Jan 16, 2019
@jreback jreback merged commit 5a15a37 into pandas-dev:master Jan 16, 2019
@jreback
Copy link
Contributor

jreback commented Jan 16, 2019

thanks!

@jbrockmendel jbrockmendel deleted the ztests branch January 16, 2019 02:57
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants