Revert unnecessary changes from 22019 #24802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time, pandas-dev#22019 seemed to break API in a few places. Since then, those API breaking changes have disappeared, so the changes to the tests and the release note are no longer necessary. Closes pandas-dev#24789
Codecov Report
@@ Coverage Diff @@
## master #24802 +/- ##
===========================================
- Coverage 92.38% 42.92% -49.47%
===========================================
Files 166 166
Lines 52382 52382
===========================================
- Hits 48395 22485 -25910
- Misses 3987 29897 +25910
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24802 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 166 166
Lines 52382 52382
=======================================
Hits 48395 48395
Misses 3987 3987
Continue to review full report at Codecov.
|
|
LGTM |
|
cc @jbrockmendel. |
|
Nice timing :) |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
At the time, pandas-dev#22019 seemed to break API in a few places. Since then, those API breaking changes have disappeared, so the changes to the tests and the release note are no longer necessary. Closes pandas-dev#24789
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
At the time, pandas-dev#22019 seemed to break API in a few places. Since then, those API breaking changes have disappeared, so the changes to the tests and the release note are no longer necessary. Closes pandas-dev#24789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time, #22019 seemed to
break API in a few places. Since then, those API breaking changes have
disappeared, so the changes to the tests and the release note are no
longer necessary.
This restores the tests to the 0.23.4 version.
Closes #24789