Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: fixturize test_to_html alignment checks #24887

Closed

Conversation

simonjayhawkins
Copy link
Member

#24873 (comment)

re-use of fixtures through indirect parametrization.

a hierarchy of fixtures to ultimately create a dataframe fixture containing 16 dataframes of combinations of named and unnamed, single level and multi index independently on the row and columns index.

this dataframe fixture is then reused through indirect parametrization of the dataframe values, the index and column index labels and the index and column index names

both the test functions consist of only two lines

result = ...
assert result == ...

the diff is a bit cluttered since a function used by the fixtures, expected_html has been moved into conftest and converted to a fixture.

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #24887 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24887   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52413    52413           
=======================================
  Hits        48425    48425           
  Misses       3988     3988
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a745d8...6ebf2c5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #24887 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24887   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52413    52413           
=======================================
  Hits        48425    48425           
  Misses       3988     3988
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a745d8...6ebf2c5. Read the comment docs.

@simonjayhawkins
Copy link
Member Author

i'll try and find an better example that'll be worthwhile merging rather than this overzealous creation of fixtures just to demonstrate indirect parametrization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant