Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Excel IO Into Sub-Directory #25153

Merged
merged 7 commits into from
Feb 11, 2019
Merged

Split Excel IO Into Sub-Directory #25153

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2aa962
Intial refactor
WillAyd Feb 5, 2019
b9142e0
Resolved import errors, circular refs
WillAyd Feb 5, 2019
323019e
LINT fixup
WillAyd Feb 5, 2019
e50fe40
LINT fixup pt 2
WillAyd Feb 5, 2019
500e3c5
isort fixup
WillAyd Feb 5, 2019
66d32bb
Merge remote-tracking branch 'upstream/master' into excel-io-split
WillAyd Feb 7, 2019
85f2fe8
Merge remote-tracking branch 'upstream/master' into excel-io-split
WillAyd Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,027 changes: 0 additions & 2,027 deletions pandas/io/excel.py
View file
Open in desktop

This file was deleted.

16 changes: 16 additions & 0 deletions pandas/io/excel/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from pandas.io.excel._base import read_excel, ExcelWriter, ExcelFile
from pandas.io.excel._openpyxl import _OpenpyxlWriter
from pandas.io.excel._util import register_writer
from pandas.io.excel._xlsxwriter import _XlsxWriter
from pandas.io.excel._xlwt import _XlwtWriter

__all__ = ["read_excel", "ExcelWriter", "ExcelFile"]


register_writer(_OpenpyxlWriter)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could obviously make this more succinct with a loop but again attempting to minimize diff

Copy link
Member

@gfyoung gfyoung Feb 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow - given that +/- 2000 line diff from git in this PR, what diff are you trying to minimize exactly?



register_writer(_XlwtWriter)


register_writer(_XlsxWriter)
Loading