Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #25171 on branch 0.24.x #25248

Merged

Conversation

albertvillanova
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Feb 9, 2019

why did u push this? backports are done automatically

@jreback
Copy link
Contributor

jreback commented Feb 9, 2019

ic you followed the manual back port instructions, ok.

@jreback jreback added this to the 0.24.2 milestone Feb 9, 2019
@jreback jreback added the IO JSON read_json, to_json, json_normalize label Feb 9, 2019
@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #25248 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25248      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +<.01%     
==========================================
  Files         166      166              
  Lines       52404    52405       +1     
==========================================
+ Hits        48410    48411       +1     
  Misses       3994     3994
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 42.88% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/json/table_schema.py 98.3% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b134253...748819c. Read the comment docs.

@albertvillanova
Copy link
Contributor Author

@jreback yes, I was asked to backport manually. All checks have passed.

@jreback jreback merged commit 5481dd1 into pandas-dev:0.24.x Feb 11, 2019
@jreback
Copy link
Contributor

jreback commented Feb 11, 2019

thanks @albertvillanova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants