Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark test_pct_max_many_rows as high memory #25400

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Mark test_pct_max_many_rows as high memory #25400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pandas/tests/frame/test_rank.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ def test_rank_pct_true(self, method, exp):
tm.assert_frame_equal(result, expected)

@pytest.mark.single
@pytest.mark.high_memory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its fine to mark, but how is this skipped on 32 bit systems?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scarabeusiv did you determine that the issue was with the low memory of the machine? That it would have happened on a 64-bit system with the same amount of RAM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep with the suspicion it would happen on the same machine with the same amount of memory.

With the patch it is building fine:
https://build.opensuse.org/package/show/devel:languages:python:numeric/python-pandas

Unrelated: do you guys care about ppc/s390 build issues? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would take patches certainly. It's a bit hard to "officially" support a platform when it's not tested regularly as part of our CI though.

@jreback does that answer your question about skipping?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should skip skip these on 32-bit (eg a conditional skip in pd.test() but can be followip

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to skip on 32 bit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep with the suspicion it would happen on the same machine with the same amount of memory.

so the issue is the available RAM, not whether the OS is 32 or 64 bit.

def test_pct_max_many_rows(self):
# GH 18271
df = DataFrame({'A': np.arange(2**24 + 1),
Expand Down
1 change: 1 addition & 0 deletions pandas/tests/series/test_rank.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,7 @@ def test_rank_first_pct(dtype, ser, exp):


@pytest.mark.single
@pytest.mark.high_memory
def test_pct_max_many_rows():
# GH 18271
s = Series(np.arange(2**24 + 1))
Expand Down
1 change: 1 addition & 0 deletions pandas/tests/test_algos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,6 +1484,7 @@ def test_too_many_ndims(self):
algos.rank(arr)

@pytest.mark.single
@pytest.mark.high_memory
@pytest.mark.parametrize('values', [
np.arange(2**24 + 1),
np.arange(2**25 + 2).reshape(2**24 + 1, 2)],
Expand Down