BUG: User-facing AssertionError with add column to SparseDataFrame #25503

charlesdong1991 · 2019-03-01T13:42:30Z

closes BUG: User-facing AssertionError with add column to SparseDataFrame #25484
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

codecov · 2019-03-01T14:19:17Z

Codecov Report

Merging #25503 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master   #25503      +/-   ##
==========================================
- Coverage   91.75%   91.75%   -0.01%     
==========================================
  Files         173      173              
  Lines       52955    52957       +2     
==========================================
  Hits        48589    48589              
- Misses       4366     4368       +2

Flag	Coverage Δ
#multiple	`90.31% <50%> (-0.01%)`	⬇️
#single	`41.72% <0%> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/sparse/frame.py	`94.65% <50%> (-0.2%)`	⬇️
pandas/util/testing.py	`87.57% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011f0a6...d2be63a. Read the comment docs.

codecov · 2019-03-01T14:19:18Z

Codecov Report

Merging #25503 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master   #25503      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files         175      175              
  Lines       52491    52493       +2     
==========================================
- Hits        48238    48236       -2     
- Misses       4253     4257       +4

Flag	Coverage Δ
#multiple	`90.44% <50%> (-0.01%)`	⬇️
#single	`40.73% <0%> (-0.15%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/sparse/frame.py	`95.5% <50%> (-0.2%)`	⬇️
pandas/io/gbq.py	`75% <0%> (-12.5%)`	⬇️
pandas/core/frame.py	`96.79% <0%> (-0.12%)`	⬇️
pandas/util/testing.py	`90.72% <0%> (+0.1%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a0948...7562481. Read the comment docs.

gfyoung · 2019-03-02T08:31:11Z

Good start! Definitely will need to add a test for this.

pep8speaks · 2019-03-02T09:15:55Z

Hello @charlesdong1991! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-12 12:21:51 UTC

simonjayhawkins · 2019-03-02T10:02:06Z

Good start! Definitely will need to add a test for this.

one of the changes will be hitting this test (updated to catch error type in #25483)

pandas/pandas/tests/sparse/frame/test_frame.py

Lines 553 to 555 in b99f8bc

    
           # insert ndarray wrong size 
        
           pytest.raises(Exception, frame.__setitem__, 'foo', 
        
                         np.random.randn(N - 1))

simonjayhawkins · 2019-03-02T10:06:31Z

pandas/tests/sparse/frame/test_frame.py

+        msg = 'Length of values does not match length of index'
+        with pytest.raises(ValueError, match=msg):
+            sp['foo'] = np.random.randn(N-1)
+


may not need an additional test (#25503 (comment))

the code sample in #25484 replicates the setup of the existing test. so maybe able to alter existing test to hit both changes you've made to pandas\core\sparse\frame.py in _sanitize_column

ahh, i see! thanks! @simonjayhawkins

jreback · 2019-03-03T01:57:01Z

can you merge master and resolve conflicts. ping on green.

jreback · 2019-03-26T00:09:15Z

can you merge master & add a whatsnew note for this. ping on green.

jreback

doc-change, otherwise lgtm. pls merge master. ping on green.

jreback · 2019-03-30T19:10:42Z

doc/source/whatsnew/v0.25.0.rst

@@ -227,7 +227,7 @@ Performance Improvements

 Bug Fixes
 ~~~~~~~~~
-
+- Bug in `SparseDataFrame` when adding a column in which the length of values does not match length of index, ``AssertionError`` is raised instead of raising ``ValueError`` (:issue:`25484`)


can you make a Sparse sub-section and move this there

okay, sparse section is already there, moved! thanks @jreback

charlesdong1991 · 2019-03-31T09:50:42Z

@jreback i merged the master and made the doc change, pls take a look, thanks

charlesdong1991 · 2019-04-12T13:10:26Z

@jreback i just merged the master and resolved the conflict, pls take a look if you have some time. thanks!

jreback · 2019-04-12T13:12:09Z

thanks @charlesdong1991

…andas-dev#25503)

gfyoung added Error Reporting Incorrect or improved errors from pandas Sparse Sparse Data Type labels Mar 2, 2019

simonjayhawkins reviewed Mar 2, 2019

View reviewed changes

jreback added this to the 0.25.0 milestone Mar 3, 2019

charlesdong1991 force-pushed the issue_25484 branch from 23b33df to 4a9f225 Compare March 3, 2019 08:05

charlesdong1991 force-pushed the issue_25484 branch 2 times, most recently from 6b5f1d7 to adf847a Compare March 26, 2019 21:43

jreback requested changes Mar 30, 2019

View reviewed changes

charlesdong1991 force-pushed the issue_25484 branch from 363aabb to 2fca2ce Compare March 31, 2019 08:37

merge master

3749db6

charlesdong1991 force-pushed the issue_25484 branch from 2fca2ce to 3749db6 Compare April 12, 2019 12:17

charlesdong1991 added 3 commits April 12, 2019 14:19

put back bashes that removed by accident

4f00463

restore changes

fbd2305

restore changes

7562481

jreback approved these changes Apr 12, 2019

View reviewed changes

jreback merged commit 835d6f0 into pandas-dev:master Apr 12, 2019

yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019

BUG: User-facing AssertionError with add column to SparseDataFrame (p…

8db4026

…andas-dev#25503)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: User-facing AssertionError with add column to SparseDataFrame #25503

BUG: User-facing AssertionError with add column to SparseDataFrame #25503

charlesdong1991 commented Mar 1, 2019

codecov bot commented Mar 1, 2019

codecov bot commented Mar 1, 2019 •

edited

Loading

gfyoung commented Mar 2, 2019

pep8speaks commented Mar 2, 2019 •

edited

Loading

simonjayhawkins commented Mar 2, 2019

simonjayhawkins Mar 2, 2019

charlesdong1991 Mar 2, 2019

jreback commented Mar 3, 2019

jreback commented Mar 26, 2019

jreback left a comment

jreback Mar 30, 2019

charlesdong1991 Mar 31, 2019

charlesdong1991 commented Mar 31, 2019

charlesdong1991 commented Apr 12, 2019

jreback commented Apr 12, 2019

BUG: User-facing AssertionError with add column to SparseDataFrame #25503

BUG: User-facing AssertionError with add column to SparseDataFrame #25503

Conversation

charlesdong1991 commented Mar 1, 2019

codecov bot commented Mar 1, 2019

Codecov Report

codecov bot commented Mar 1, 2019 • edited Loading

Codecov Report

gfyoung commented Mar 2, 2019

pep8speaks commented Mar 2, 2019 • edited Loading

Comment last updated at 2019-04-12 12:21:51 UTC

simonjayhawkins commented Mar 2, 2019

simonjayhawkins Mar 2, 2019

Choose a reason for hiding this comment

charlesdong1991 Mar 2, 2019

Choose a reason for hiding this comment

jreback commented Mar 3, 2019

jreback commented Mar 26, 2019

jreback left a comment

Choose a reason for hiding this comment

jreback Mar 30, 2019

Choose a reason for hiding this comment

charlesdong1991 Mar 31, 2019

Choose a reason for hiding this comment

charlesdong1991 commented Mar 31, 2019

charlesdong1991 commented Apr 12, 2019

jreback commented Apr 12, 2019

codecov bot commented Mar 1, 2019 •

edited

Loading

pep8speaks commented Mar 2, 2019 •

edited

Loading