Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Cleanup docstring pandas.core.filter #25618

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

MishaVeldhoen
Copy link
Contributor

@MishaVeldhoen MishaVeldhoen commented Mar 9, 2019

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Made parameter description of the pandas.core.filter docstring clearer. PEP8 fix in example, see also comments in #20148.

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #25618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25618   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         173      173           
  Lines       52968    52968           
=======================================
  Hits        48339    48339           
  Misses       4629     4629
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 93.65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976a2db...e06bd23. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #25618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25618   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         173      173           
  Lines       52968    52968           
=======================================
  Hits        48339    48339           
  Misses       4629     4629
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 93.65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976a2db...e06bd23. Read the comment docs.

@gfyoung gfyoung added the Docs label Mar 9, 2019
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillAyd WillAyd added this to the 0.25.0 milestone Mar 9, 2019
@WillAyd WillAyd merged commit e28ae70 into pandas-dev:master Mar 9, 2019
@WillAyd
Copy link
Member

WillAyd commented Mar 9, 2019

Thanks @MishaVeldhoen !

@MishaVeldhoen MishaVeldhoen deleted the filter_docstring_cleanup branch March 9, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants