Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove '# -*- coding: utf-8 -*-' pattern #26197

Merged
merged 3 commits into from
Apr 28, 2019
Merged

CLN: remove '# -*- coding: utf-8 -*-' pattern #26197

merged 3 commits into from
Apr 28, 2019

Conversation

topper-123
Copy link
Contributor

Remove usage of -# -*- coding: utf-8 -*- pattern from code base.

WillAyd
WillAyd requested changes Apr 23, 2019
View reviewed changes
pandas/tests/tseries/offsets/__init__.py Outdated
@@ -1 +1 @@
# -*- coding: utf-8 -*-

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well make this an empty file for consistency in codebase

@topper-123
Copy link
Contributor Author

Same error as in #26177. Must be external to my PRs.

@WillAyd
Copy link
Member

WillAyd commented Apr 23, 2019

cc @simonjayhawkins if you have any thoughts on CI failure

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26197 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26197      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52372    52365       -7     
==========================================
- Hits        48176    48166      -10     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.53% <ø> (-0.01%) ⬇️
#single 40.69% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/core/strings.py 98.86% <ø> (ø) ⬆️
pandas/io/formats/format.py 97.9% <ø> (-0.01%) ⬇️
pandas/io/formats/latex.py 100% <ø> (ø) ⬆️
pandas/core/accessor.py 98.79% <ø> (-0.02%) ⬇️
pandas/io/formats/csvs.py 98.19% <ø> (-0.02%) ⬇️
pandas/core/internals/blocks.py 94.08% <ø> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.79% <ø> (ø) ⬆️
pandas/_libs/__init__.py 100% <ø> (ø) ⬆️
pandas/_libs/tslibs/__init__.py 100% <ø> (ø) ⬆️
pandas/core/arrays/period.py 98.53% <ø> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74901b...0f31975. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 23, 2019 •
edited
Loading

Codecov Report

Merging #26197 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26197      +/-   ##
==========================================
- Coverage   91.97%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52379    52372       -7     
==========================================
- Hits        48178    48167      -11     
- Misses       4201     4205       +4
Flag Coverage Δ
#multiple 90.52% <ø> (-0.01%) ⬇️
#single 40.7% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/strings.py 98.86% <ø> (ø) ⬆️
pandas/io/formats/format.py 97.9% <ø> (-0.01%) ⬇️
pandas/io/formats/latex.py 100% <ø> (ø) ⬆️
pandas/core/accessor.py 98.79% <ø> (-0.02%) ⬇️
pandas/io/formats/csvs.py 98.19% <ø> (-0.02%) ⬇️
pandas/core/internals/blocks.py 94.08% <ø> (ø) ⬆️
pandas/core/arrays/datetimes.py 97.79% <ø> (ø) ⬆️
pandas/_libs/__init__.py 100% <ø> (ø) ⬆️
pandas/_libs/tslibs/__init__.py 100% <ø> (ø) ⬆️
pandas/core/arrays/period.py 98.53% <ø> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65466f0...20d4c70. Read the comment docs.

jreback
jreback requested changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint error, also can you add a rule to code_checks to fail on this

@jreback jreback added this to the 0.25.0 milestone Apr 24, 2019
@jreback
Copy link
Contributor

jreback commented Apr 24, 2019

@topper-123 code checks rule could be followup

@topper-123 topper-123 force-pushed the clean_python2_encoding branch 2 times, most recently from 1344274 to a06c969 Compare April 24, 2019 14:57
@topper-123
Copy link
Contributor Author

topper-123 commented Apr 24, 2019 •
edited
Loading

I've rebased and made the changes requested.

EDIT: I've also made changes to code_checks.sh.

jschendel
jschendel reviewed Apr 24, 2019
View reviewed changes
ci/code_checks.sh Outdated Show resolved Hide resolved
jschendel
jschendel reviewed Apr 24, 2019
View reviewed changes
ci/code_checks.sh Outdated Show resolved Hide resolved
WillAyd
WillAyd approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auvipy auvipy mentioned this pull request Apr 28, 2019
Closed
@jreback jreback merged commit 96dd2a9 into pandas-dev:master Apr 28, 2019
@jreback
Copy link
Contributor

jreback commented Apr 28, 2019

thanks @topper-123

@topper-123 topper-123 deleted the clean_python2_encoding branch May 1, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschendel jschendel jschendel left review comments

@WillAyd WillAyd WillAyd approved these changes

@auvipy auvipy auvipy approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
6 participants
@topper-123 @WillAyd @jreback @jschendel @auvipy @gfyoung