DOC: Fix validation error type RT01 and check in CI (#25356)
#26234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except errors in accessor.py, op.py and some errors in resample.py, frame.py
Codecov Report
@@ Coverage Diff @@
## master #26234 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.01%
==========================================
Files 175 175
Lines 52372 52373 +1
==========================================
- Hits 48172 48168 -4
- Misses 4200 4205 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26234 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52302 52302
==========================================
- Hits 48142 48137 -5
- Misses 4160 4165 +5
Continue to review full report at Codecov.
|
WillAyd
requested changes
Apr 29, 2019
ihsansecer
added a commit
to ihsansecer/pandas
that referenced
this pull request
Apr 29, 2019
These functions return a function either with empty return statement or doesn’t return. It causes docstring validation error with type RT01 (See pandas-dev#26234).
1 task
ihsansecer
changed the title
RT01 and check in CIRT01 and check in CI (#25356)
4 tasks
Co-Authored-By: ihsansecer <abdullahsecer@std.sehir.edu.tr>
datapythonista
approved these changes
May 7, 2019
|
Looks like some conflicts can you merge master and resolve? |
Resolve conflicts with removed Panel references
|
@WillAyd resolved |
WillAyd
approved these changes
May 8, 2019
|
Thanks @ihsansecer - very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RT01and check in CI #25356./scripts/validate_docstrings.py --errors=RT01git diff upstream/master -u -- "*.py" | flake8 --diff