CLN: remove __bytes__ #26447
CLN: remove __bytes__ #26447
Conversation
topper-123
force-pushed
the
remove__bytes__
branch
from
8dbaa07
to
e1061be
Compare
Codecov Report
@@ Coverage Diff @@
## master #26447 +/- ##
==========================================
- Coverage 41.77% 41.69% -0.09%
==========================================
Files 174 174
Lines 50754 50746 -8
==========================================
- Hits 21205 21160 -45
- Misses 29549 29586 +37
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26447 +/- ##
==========================================
- Coverage 91.73% 91.73% -0.01%
==========================================
Files 174 174
Lines 50754 50746 -8
==========================================
- Hits 46560 46551 -9
- Misses 4194 4195 +1
Continue to review full report at Codecov.
|
| @@ -38,7 +38,6 @@ def test_tricky_container(self): | |||
| pytest.skip('Need unicode_container to test with this') | |||
| repr(self.unicode_container) | |||
| str(self.unicode_container) | |||
| bytes(self.unicode_container) | |||
There was a problem hiding this comment.
This raises in the FrozenList case, but not the FrozenNDArray case. So I move the bytes test to test_frozen.py and have seperate tests for FrozenList and FrozenNDArray.
topper-123
force-pushed
the
remove__bytes__
branch
from
e1061be
to
2053dfa
Compare
| def test_bytestring_with_unicode(self): | ||
| df = DataFrame({'A': ["\u05d0"]}) | ||
| bytes(df) | ||
| def test_str_to_bytes_raises(self): |
There was a problem hiding this comment.
I think OK to just remove these tests; error message just matches stdlib
There was a problem hiding this comment.
Why not just keep them? these things are now (after this PR) supposed to raise,so just have a test for that?
There was a problem hiding this comment.
I'm not hugely tied to it but these tests are making assertions about things that the stdlib does instead of something pandas explicitly does, so just seems strange to me that have that in our test suite. Let's see what others think
There was a problem hiding this comment.
Ok, I see your point. Not a hard point for me either. I can remove them later tonight.
There was a problem hiding this comment.
i think these tests are fine; pretty innocuous and prevent adding back a __bytes__.
|
these tests are ok, no big deal that we have a slight duplication with the std library. |
|
thanks @topper-123 |
Remove
__bytes__method fromStringMixinandPandasExtensionDtype. These are the only uses of__bytes__in the code base.