CLN: Remove ExcelWriter.sheetname

[mroeschke]

• xref DEPR: Clean up list of deprecations from prior versions #6581
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

cc @WillAyd

[WillAyd]

Thanks for the PR! Does this raise now? IIRC we have had some issues with confusion in the past where the kwargs would silently get swallowed (see #25723 as an example with the ExcelWriter) so this may have an unfortunate side effect of working but in a way that silently does the wrong thing.

I see there's already a special case to raise a ValueError is sheet is supplied so might be a good idea to do the same thing here if this doesn't raise

[codecov]

Codecov Report

Merging #26464 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #26464      +/-   ##
==========================================
- Coverage   91.76%   91.74%   -0.02%     
==========================================
  Files         174      174              
  Lines       50673    50665       -8     
==========================================
- Hits        46498    46485      -13     
- Misses       4175     4180       +5

Flag	Coverage Δ
#multiple	90.26% <100%> (-0.01%)	⬇️
#single	41.71% <0%> (-0.08%)	⬇️

Impacted Files	Coverage Δ
pandas/io/excel/_base.py	91.85% <100%> (-0.29%)	⬇️
pandas/io/gbq.py	78.94% <0%> (-10.53%)	⬇️
pandas/core/frame.py	97% <0%> (-0.12%)	⬇️
pandas/util/testing.py	90.6% <0%> (-0.11%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374478c...1b1c7a3. Read the comment docs.

[codecov]

Codecov Report

Merging #26464 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26464      +/-   ##
==========================================
- Coverage   91.74%   91.74%   -0.01%     
==========================================
  Files         174      174              
  Lines       50763    50755       -8     
==========================================
- Hits        46575    46563      -12     
- Misses       4188     4192       +4

Flag	Coverage Δ
#multiple	90.25% <ø> (-0.01%)	⬇️
#single	41.71% <ø> (-0.08%)	⬇️

Impacted Files	Coverage Δ
pandas/io/excel/_base.py	91.85% <ø> (-0.29%)	⬇️
pandas/io/gbq.py	78.94% <0%> (-10.53%)	⬇️
pandas/core/frame.py	97.02% <0%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d5498...569a649. Read the comment docs.

[mroeschke]

You were right, @WillAyd. sheetname would just get swallowed by **kwargs and not raise. I added additional code & test for the correct raising behavior.

[WillAyd]

Actually is this part of ExcelWriter or read_excel? From the diff I think this should be changed to the latter

[mroeschke]

Thanks for the catch! I shamelessly copied ExcelWriter from the deprecated issue (which was probably incorrect)

[WillAyd]

lgtm

[jreback]

lgtm. can you merge master (as @WillAyd test refactor was merged); merge on green.

[jreback]

tick the box in #13777 when merged.

[gfyoung]

LGTM

Leave it to you if you want to throw parse_cols in here as well

[gfyoung]

Thanks @mroeschke !