Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/CLN: Change API reference section title #26486

Merged
merged 1 commit into from
May 24, 2019

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@simonjayhawkins
Copy link
Member Author

i'm not sure whats best here, Indexes, Indices, Index Types, but Indexing is not appropriate.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #26486 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26486      +/-   ##
==========================================
- Coverage   91.75%   91.74%   -0.01%     
==========================================
  Files         174      174              
  Lines       50761    50761              
==========================================
- Hits        46574    46571       -3     
- Misses       4187     4190       +3
Flag Coverage Δ
#multiple 90.25% <ø> (ø) ⬆️
#single 41.71% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b92e7e...d3a1a47. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #26486 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26486      +/-   ##
==========================================
- Coverage   91.75%   91.74%   -0.01%     
==========================================
  Files         174      174              
  Lines       50761    50761              
==========================================
- Hits        46574    46571       -3     
- Misses       4187     4190       +3
Flag Coverage Δ
#multiple 90.25% <ø> (ø) ⬆️
#single 41.71% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b92e7e...d3a1a47. Read the comment docs.

@WillAyd
Copy link
Member

WillAyd commented May 22, 2019

Do we have any references to this elsewhere in the docs?

@WillAyd WillAyd added the Docs label May 22, 2019
@simonjayhawkins
Copy link
Member Author

@WillAyd do you mean links to this page, or using the term Indexing to refer to index types?

i've left the name of the file unchanged (indexing.rst) so links shouldn't be affected, but the title is changed so that the Table of Contents makes more sense. Am i missing something? i've not done much on the docs before.

@WillAyd
Copy link
Member

WillAyd commented May 22, 2019

I mean any implicit hyperlink targets to the section, but looks like there's an explicit name anyway (api.indexing) so should be OK

@WillAyd WillAyd added this to the 0.25.0 milestone May 22, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. @datapythonista if you want to take a look

@jorisvandenbossche jorisvandenbossche merged commit 3de0453 into pandas-dev:master May 24, 2019
@jorisvandenbossche
Copy link
Member

Thanks!

another-green pushed a commit to another-green/pandas that referenced this pull request May 29, 2019
@simonjayhawkins simonjayhawkins deleted the api_title branch May 29, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants