Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF/CI: fix benchmark import error + run asv check on all builds #26575

Merged
merged 4 commits into from
May 30, 2019
Merged

PERF/CI: fix benchmark import error + run asv check on all builds #26575

merged 4 commits into from
May 30, 2019

Conversation

pv
Copy link
Contributor

@pv pv commented May 30, 2019 •
edited
Loading

Fix benchmark suite import error on master and 0.23.
Run asv check on all commits to lint the benchmark suite.

Also, fixed a timeout error that appears on newer asv versions,
which have an updated asizeof.py module.

WillAyd
WillAyd requested changes May 30, 2019
View reviewed changes
asv_bench/benchmarks/groupby.py Outdated Show resolved Hide resolved
asv_bench/benchmarks/io/parsers.py Show resolved Hide resolved
@WillAyd WillAyd added the Benchmark Performance (ASV) benchmarks label May 30, 2019
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #26575 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26575      +/-   ##
==========================================
- Coverage   91.84%   91.84%   -0.01%     
==========================================
  Files         174      174              
  Lines       50643    50643              
==========================================
- Hits        46515    46511       -4     
- Misses       4128     4132       +4
Flag Coverage Δ
#multiple 90.37% <ø> (ø) ⬆️
#single 41.71% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60d1bd...6020370. Read the comment docs.

@codecov
Copy link

codecov bot commented May 30, 2019 •
edited
Loading

Codecov Report

Merging #26575 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26575      +/-   ##
==========================================
- Coverage   91.84%   91.84%   -0.01%     
==========================================
  Files         174      174              
  Lines       50643    50643              
==========================================
- Hits        46515    46511       -4     
- Misses       4128     4132       +4
Flag Coverage Δ
#multiple 90.37% <ø> (ø) ⬆️
#single 41.71% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60d1bd...69a617f. Read the comment docs.

@pv pv force-pushed the bench-check branch 2 times, most recently from 5a2459c to 0f19826 Compare May 30, 2019 15:43
@pv
PERF: fix benchmark frame_methods.Iteration.mem_itertuples_to_list
69a617f 
The runtime of the benchmark increased in asv 0.4 (which has upgraded
asv.extern.asizeof), so bump the timeout upward.
@WillAyd
Copy link
Member

WillAyd commented May 30, 2019

So I see the benchmark step took 15 minutes in this PR - that would essentially run every time now right?

@pv
Copy link
Contributor Author

pv commented May 30, 2019 •
edited
Loading

No, asv check takes a few seconds. The second part of the benchmark check, which is not changed in this PR, still runs in the same way as before this PR --- only when the benchmark suite itself has been changed.

@WillAyd
Copy link
Member

WillAyd commented May 30, 2019

Makes sense - wasn't registering at first that the benchmarks here are part of the diff :-)

WillAyd
WillAyd approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomAugspurger

@TomAugspurger TomAugspurger merged commit 7c8041b into pandas-dev:master May 30, 2019
@TomAugspurger
Copy link
Contributor

Thanks @pv!

@TomAugspurger TomAugspurger added this to the 0.25.0 milestone May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pv @WillAyd @TomAugspurger