Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NDFrame.select #26641

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Remove NDFrame.select #26641

merged 1 commit into from
Jun 4, 2019

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Jun 3, 2019 •
edited
Loading

Removes NDFrame.select, that was deprecated in 0.21.

@topper-123 topper-123 added this to the 0.25.0 milestone Jun 3, 2019
@topper-123 topper-123 added Indexing Related to indexing on series/frames, not to indexes themselves and removed API Design labels Jun 3, 2019
@topper-123 topper-123 mentioned this pull request Jun 4, 2019
Open
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #26641 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26641      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50692    50683       -9     
==========================================
- Hits        46575    46563      -12     
- Misses       4117     4120       +3
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.79% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 93.63% <ø> (+0.02%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1013706...64ed9c3. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 4, 2019 •
edited
Loading

Codecov Report

Merging #26641 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26641      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50692    50683       -9     
==========================================
- Hits        46575    46563      -12     
- Misses       4117     4120       +3
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.79% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 93.63% <ø> (+0.02%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1013706...64ed9c3. Read the comment docs.

WillAyd
WillAyd approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback mentioned this pull request Jun 4, 2019
Closed
@gfyoung gfyoung merged commit e25fd0d into pandas-dev:master Jun 4, 2019
@gfyoung
Copy link
Member

gfyoung commented Jun 4, 2019

Thanks @topper-123 !

@topper-123 topper-123 deleted the remove_ndframe.select branch June 5, 2019 09:06
vaibhavhrt pushed a commit to vaibhavhrt/pandas that referenced this pull request Jun 6, 2019
@topper-123 @vaibhavhrt
Remove NDFrame.select (pandas-dev#26641)
dbdd556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@topper-123 @gfyoung @WillAyd