Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove read_table deprecation #27102

Merged
merged 4 commits into from
Jun 28, 2019

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jun 28, 2019

Let me know if the whatsnew note should be a special section in the Deprecation section.

@mroeschke mroeschke added this to the 0.25.0 milestone Jun 28, 2019
@jreback jreback added IO Data IO issues that don't fit into a more specific label Deprecate Functionality to remove in pandas labels Jun 28, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

@@ -872,6 +872,7 @@ Other
- Allow :class:`Index` and :class:`RangeIndex` to be passed to numpy ``min`` and ``max`` functions (:issue:`26125`)
- Use actual class name in repr of empty objects of a ``Series`` subclass (:issue:`27001`).
- Bug in :class:`DataFrame` where passing an object array of timezone-aware `datetime` objects would incorrectly raise ``ValueError`` (:issue:`13287`)
- func:`read_table` has been undeprecated (:issue:`25220`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note in the v0.24.0 docs as well that the deprecation was removed in 0.25.0 for people reading that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not sure where it first better, but I don't think the bugs section is were to put it. Maybe in the deprecations section, since it is most related to that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I editing the whatsnew entry in v0.24.0 for the read_table deprecation to mention it was undeprecated in 0.25.0

@mroeschke mroeschke merged commit ad18ea3 into pandas-dev:master Jun 28, 2019
@mroeschke mroeschke deleted the remove_read_table_deprecation branch June 28, 2019 20:04
niltonlk added a commit to niltonlk/nest-simulator that referenced this pull request Jun 7, 2020
… deprecation warning by replacing to pyplot.sca(ax). There is also a pandas deprecation warning regarding read_table, which was un-deprecated in pandas 0.25.0 (pandas-dev/pandas#27102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO Data IO issues that don't fit into a more specific label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep (un-deprecate) read_table() for API stability
3 participants