DEPR: deprecate msgpack support #27103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/io/packers.py
Outdated
| @@ -92,6 +91,12 @@ def to_msgpack(path_or_buf, *args, **kwargs): | |||
| compress : type of compressor (zlib or blosc), default to None (no | |||
| compression) | |||
| """ | |||
| warnings.warn("The read_msgpack is deprecated and will be removed in a " | |||
There was a problem hiding this comment.
Suggested change
| warnings.warn("The read_msgpack is deprecated and will be removed in a " | |
| warnings.warn("The to_msgpack is deprecated and will be removed in a " |
pandas/io/packers.py
Outdated
| "future version.\n" | ||
| "It is recommended to use pyarrow for on-the-wire " | ||
| "transmission of pandas objects.", | ||
| FutureWarning, stacklevel=2) |
There was a problem hiding this comment.
this probably needs to be a stacklevel of 3 (since it is called from DataFrame.to_msgpack)
1 task
|
I’m generally on board with this, but concerned about the fact that msgpack uses internals, so if this becomes “downstream” then that may make it harder to simplify things in internals if we are worried about breaking downstream. |
that’s all the more reason to deprecate this actually. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27084