CLN: remove fastparquet compat shim #27170
Conversation
| @@ -3040,8 +3028,7 @@ def get_block_type(values, dtype=None): | |||
| return cls | |||
|
|
|||
|
|
|||
| def make_block(values, placement, klass=None, ndim=None, dtype=None, | |||
| fastpath=None): | |||
| def make_block(values, placement, klass=None, ndim=None, dtype=None): | |||
There was a problem hiding this comment.
if you can type things would be great (new PR)
|
lgtm. |
|
I guess fastparquet 0.2.1 still has the offending code. Can you add an issue to their tracker? (this is the failing build) |
Looks like Tom beat me to it by about 2 weeks |
|
I'll push a fix to fastparquet for the issue. |
|
I'd recommend skipping for fastparquet <0.3.2
…On Mon, Jul 1, 2019 at 9:21 PM jbrockmendel ***@***.***> wrote:
Can you add an issue to their tracker?
Looks like Tom beat me to it by about 2 weeks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#27170?email_source=notifications&email_token=AAKAOIRVMXTMT5OJXVX7ZF3P5K3TRA5CNFSM4H4WEHJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY73LPQ#issuecomment-507491774>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIVOGIORGMWR26QZI4LP5K3TRANCNFSM4H4WEHJA>
.
|
we can’t skip as that just papers over; we would need to bump or not merge this patch |
|
Let's leave this for after 0.25.0 then, or at least until there is a new fastparquet release with the fix. It's a bit unfortunate that fastparquet didn't fix that a year ago. |
|
Waiting may be prudent. I'm going to try to do a FP release today.
…On Tue, Jul 2, 2019 at 8:50 AM Joris Van den Bossche < ***@***.***> wrote:
Let's leave this for after 0.25.0 then, or at least until there is a new
fastparquet release with the fix. It's a bit unfortunate that fastparquet
didn't fix that a year ago.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27170?email_source=notifications&email_token=AAKAOIQD2WDPZ7NB6REHIATP5NMJXA5CNFSM4H4WEHJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZBKXNQ#issuecomment-507685814>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOISOB3NUWNOYTD4YC5DP5NMJXANCNFSM4H4WEHJA>
.
|
|
@TomAugspurger should I stick a pin in this for [?] weeks? |
|
yeah I think we need FP release around for a while before we can do this. |
|
Closing to clear the queue, will revisit a release or two from now |
Introduced in #19434 Jan 2018.