Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERR: Raise on duplicates names in read_csv #27175

Merged
merged 4 commits into from
Jul 2, 2019
Merged

ERR: Raise on duplicates names in read_csv #27175

merged 4 commits into from
Jul 2, 2019

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Clean Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv labels Jul 2, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Jul 2, 2019
WillAyd
WillAyd approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @mroeschke

@jreback jreback merged commit e145443 into pandas-dev:master Jul 2, 2019
@jreback
Copy link
Contributor

jreback commented Jul 2, 2019

thanks @mroeschke

@mroeschke mroeschke deleted the clean_dup_names_read_csv branch July 2, 2019 15:08
@jbrockmendel
Copy link
Member

@mroeschke should the entry for this in #6581 be moved to #13777? (also the docstring for _validate_names is now inaccurate)

@mroeschke
Copy link
Member Author

@jbrockmendel Good catch. Looks like I forgot to move it to #13777 after this PR was merged.

@jbrockmendel
Copy link
Member

which version did this make it into?

@jbrockmendel
Copy link
Member

Looks like 0.25.0

@jreback jreback mentioned this pull request Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @jreback @jbrockmendel @WillAyd