DEPR: make Categorical.ravel() return Categorical #27199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
approved these changes
Jul 3, 2019
jreback
added
Categorical
1 task
|
conflict and failing otherwise lgtm. |
jreback
reviewed
Jul 3, 2019
pandas/tests/extension/base/base.py
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
|
|
|||
| class BaseExtensionTests: | |||
| # Whether the EA being tested supports __setitem__ | |||
| _supports_setitem = True | |||
There was a problem hiding this comment.
I guess this is ok, but in reality you should have a class which does this (future PR)
|
I am a little concerned by the change in testing pattern this introduces. Could we remove this for now. |
|
testing pattern reverted |
|
lgtm. merge on green. |
|
thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #27142.
git diff upstream/master -u -- "*.py" | flake8 --diff